Remove SSLPrivateKey metadata hooks

Desktop / Chromium - davidben [chromium.org] - 19 April 2017 18:20 EDT

These are no longer needed; BoringSSL just extracts them from the certificate itself. Some of the SSLPrivateKey implementations still need this metadata and platform APIs are unreliable, so keep GetClientCertInfo around for that. Though some of it can be extracted from the signature type when we finally update to TLS 1.3.

BUG=none

Review-Url: https://codereview.chromium.org/2822283002 Cr-Commit-Position: refs/heads/master@{#465780}

e422380 Remove SSLPrivateKey metadata hooks.
.../certificate_provider/certificate_info.h | 3 --
.../certificate_provider_service.cc | 14 ------
.../certificate_provider_service_unittest.cc | 9 +---
.../certificate_provider_api.cc | 6 ---
net/log/net_log_event_type_list.h | 1 -
net/socket/ssl_client_socket_impl.cc | 57 ++--------------------
net/socket/ssl_client_socket_impl.h | 2 -
net/ssl/openssl_client_key_store_unittest.cc | 10 ----
net/ssl/ssl_client_auth_cache_unittest.cc | 7 ---
net/ssl/ssl_platform_key_android.cc | 15 +++---
net/ssl/ssl_platform_key_android_unittest.cc | 19 ++++----
net/ssl/ssl_platform_key_chromecast.cc | 9 ----
net/ssl/ssl_platform_key_mac.cc | 32 ++++--------
net/ssl/ssl_platform_key_mac_unittest.cc | 12 ++---
net/ssl/ssl_platform_key_nss.cc | 22 +++------
net/ssl/ssl_platform_key_nss_unittest.cc | 15 +++---
net/ssl/ssl_platform_key_util.cc | 34 +------------
net/ssl/ssl_platform_key_util.h | 6 +--
net/ssl/ssl_platform_key_util_unittest.cc | 13 ++---
net/ssl/ssl_platform_key_win.cc | 31 ++++--------
net/ssl/ssl_private_key.h | 25 ----------
net/ssl/ssl_private_key_test_util.cc | 46 +----------------
net/ssl/ssl_private_key_test_util.h | 4 +-
net/ssl/test_ssl_private_key.cc | 43 ++--------------
net/ssl/threaded_ssl_private_key.cc | 8 ---
net/ssl/threaded_ssl_private_key.h | 8 +--
26 files changed, 82 insertions(+), 369 deletions(-)

Upstream: git.chromium.org


  • Share