shelf: Add a back button to the shelf

Desktop / Chromium - Sammie Quon [google.com] - 14 July 2017 15:11 EDT

This is in preparation for removing title bars work. See mocks in the bug and screenshots for more details. This approach of adding a back button expands the current app list button to be modal and have two functionalities depending on which side is pressed. The alternative (seperate back button) is IMO very difficult to achieve what is shown in the mocks (namely the color in between and animation (not in this CL) of said color in between). The exact functionality of the back button is not 100% defined yet, this CL just sends a VKEY_BROWSER_BACK event in the meantime.

Screenshots: https://screenshot.googleplex.com/ZVNP0aq0cc3 https://screenshot.googleplex.com/fDcGTuoyZg5 https://screenshot.googleplex.com/ZFBzk72LLVt

Test: ash_unittests --gtest_filter="ShelfViewInkDropTest.*" Bug: 721940 Change-Id: I699c6d971aea89ba201536ca8534a14b4d44b0e2 Reviewed-on: https://chromium-review.googlesource.com/555836 Commit-Queue: Sammie Quon

4f552ac shelf: Add a back button to the shelf.
ash/resources/vector_icons/BUILD.gn | 2 +
ash/resources/vector_icons/shelf_back.1x.icon | 24 ++++
ash/resources/vector_icons/shelf_back.icon | 23 +++
ash/shelf/app_list_button.cc | 194 ++++++++++++++++++++++++--
ash/shelf/app_list_button.h | 24 +++-
ash/shelf/shelf_view.cc | 23 ++-
ash/shelf/shelf_view_unittest.cc | 124 ++++++++++++++++
ash/shelf/voice_interaction_overlay.cc | 6 +-
8 files changed, 394 insertions(+), 26 deletions(-)

Upstream: git.chromium.org


  • Share