Start EditableCombobox

Desktop / Chromium - Edin Kadric [google.com] - 27 February 2019 16:01 EST

See associated bug for design doc and screen recording showing the new control.

This CL gets us most of the way there, but there are still things to do in subsequent CLs before we start using this control:- I only tested this on Mac for now. I will add support for other OSes later.- The accessibility isn't quite right. It says to select with control+option+space, but that doesn't work. I noticed that it doesn't work for the regular Combobox either, so I will fix it for both in a later CL.

Bug: 923660 Change-Id: I8e959e068af23491a842c4bc0fa9661cbd2869dd Reviewed-on: https://chromium-review.googlesource.com/c/1466186 Commit-Queue: Edin Kadric

45cb4bec233b Start EditableCombobox.
ui/views/BUILD.gn | 9 +
ui/views/cocoa/bridged_native_widget_host_impl.mm | 4 +-
.../editable_combobox/editable_combobox.cc | 301 ++++++++++++
.../controls/editable_combobox/editable_combobox.h | 140 ++++++
.../editable_combobox/editable_combobox_listener.h | 28 ++
.../editable_combobox_unittest.cc | 541 +++++++++++++++++++++
ui/views/controls/menu/menu_config.cc | 2 +-
ui/views/controls/menu/menu_controller.cc | 74 ++-
ui/views/controls/menu/menu_controller.h | 18 +-
ui/views/controls/menu/menu_controller_unittest.cc | 7 +-
ui/views/controls/menu/menu_item_view.cc | 2 +-
ui/views/controls/menu/menu_runner.h | 5 +
ui/views/controls/menu/menu_runner_impl.cc | 9 +-
13 files changed, 1112 insertions(+), 28 deletions(-)

Upstream: git.chromium.org


  • Share