Start refactor of QuicCryptoStream

Desktop / Chromium - Nick Harper [chromium.org] - 12 July 2017 20:34 EDT

QuicCryptoClientStream and QuicCryptoServerStream are refactored to delegate their implementations to a CryptoClientStreamDelegate or CryptoServerStreamDelegate, and the existing implementations are moved to new subclasses of the new delegates.

The major work left to do in this refactor is for QuicCryptoStream to no longer implement CryptoFramerVisitorInterface and to remove the OnHandshakeMessage method from CryptoClientStreamDelegate and CryptoServerStreamDelegate interfaces.

Merge internal change: 161549072

Change-Id: I3919d067028cdacd939c64be4362d4645d7e7e65 Reviewed-on: https://chromium-review.googlesource.com/565978 Commit-Queue: Nick Harper

e45fe4f Start refactor of QuicCryptoStream
.../chromium/quic_chromium_client_session_peer.cc | 7 -
.../chromium/quic_chromium_client_session_peer.h | 3 -
.../chromium/quic_chromium_client_session_test.cc | 30 ++-
net/quic/core/quic_crypto_client_stream.cc | 243 +++++++++++++--------
net/quic/core/quic_crypto_client_stream.h | 108 ++++++++-
net/quic/core/quic_crypto_client_stream_test.cc | 8 +
net/quic/core/quic_crypto_server_stream.cc | 216 +++++++++++++-----
net/quic/core/quic_crypto_server_stream.h | 139 +++++++++++-
8 files changed, 578 insertions(+), 176 deletions(-)

Upstream: git.chromium.org


  • Share