Unified error handling for WritableStream

Desktop / Chromium - ricea [chromium.org] - 19 April 2017 01:29 EDT

Port the standard changes in https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are listed at the above URL. This implementation has no known deviations from the standard.

The brings this implementation up to parity with https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db8c32.

This CL also removes failing test expectations. Issue 626703 and 711529 cover lines that were removed from TestExpectations.

BUG=711254,626703,711529,684543

Review-Url: https://codereview.chromium.org/2823563002 Cr-Commit-Position: refs/heads/master@{#465498}

6703f4d Unified error handling for WritableStream
third_party/WebKit/LayoutTests/TestExpectations | 13 -
.../streams/writable-streams/aborting-expected.txt | 52 ---
.../aborting.dedicatedworker-expected.txt | 52 ---
.../aborting.serviceworker.https-expected.txt | 53 ---
.../aborting.sharedworker-expected.txt | 52 ---
.../streams/writable-streams/close-expected.txt | 21 -
.../close.dedicatedworker-expected.txt | 21 -
.../close.serviceworker.https-expected.txt | 22 --
.../close.sharedworker-expected.txt | 21 -
.../writable-streams/constructor-expected.txt | 15 -
.../constructor.dedicatedworker-expected.txt | 15 -
.../constructor.serviceworker.https-expected.txt | 16 -
.../constructor.sharedworker-expected.txt | 15 -
.../streams/writable-streams/error-expected.txt | 8 -
.../error.dedicatedworker-expected.txt | 8 -
.../error.serviceworker.https-expected.txt | 10 -
.../error.sharedworker-expected.txt | 8 -
.../writable-streams/properties-expected.txt | 47 ---
.../properties.dedicatedworker-expected.txt | 47 ---
.../properties.serviceworker.https-expected.txt | 48 ---
.../properties.sharedworker-expected.txt | 47 ---
.../piping/multiple-propagation.https-expected.txt | 25 --
.../streams/piping/multiple-propagation.https.html | 14 -
.../tests/streams/piping/multiple-propagation.js | 139 -------
.../WebKit/Source/core/streams/WritableStream.js | 422 ++++++++++++---------
25 files changed, 233 insertions(+), 958 deletions(-)

Upstream: git.chromium.org


  • Share