Use a PrefService and enable extended Safe Browsing reporting (by means of opt-in).

Desktop / Chromium - Tim Volodine [chromium.org] - 14 July 2017 12:34 EDT

In this patch:- Refactoring in order to use a PrefService for obtaining and updating the preference values related to the interstitials.- Use the pref service for setting the default values (for the display options).- Enable user opt-in (using a check box) for the extended reporting when the interstitial is shown.- Update AwSafeBrowsingUIManager::SetExtendedReportingAllowed to modify the corresponding PrefService preference (instead of keeping a boolean inside the class).

BUG=700351, 688629

Change-Id: Ifa2e2c692670213e792d05c5d3cb0ba7facc74f7 Reviewed-on: https://chromium-review.googlesource.com/567144

192d555 Use a PrefService and enable extended Safe Browsing reporting (by means of opt-in).
android_webview/browser/aw_browser_context.cc | 6 ++++--
.../browser/aw_safe_browsing_blocking_page.cc | 18 +++++++++++-------
.../browser/aw_safe_browsing_blocking_page.h | 4 +++-
.../browser/aw_safe_browsing_resource_throttle.cc | 4 ++--
android_webview/browser/aw_safe_browsing_ui_manager.cc | 13 ++++++++++---
android_webview/browser/aw_safe_browsing_ui_manager.h | 12 +++++++-----
.../test_safe_browsing_blocking_page_quiet.cc | 16 +++++++++-------
components/safe_browsing/base_blocking_page.cc | 8 +++++---
components/safe_browsing/base_blocking_page.h | 3 ++-
.../security_interstitials/core/controller_client.cc | 1 +
10 files changed, 54 insertions(+), 31 deletions(-)

Upstream: git.chromium.org


  • Share