AGESA binaryPI: Consolidate and fix sleep states

Hardware / Coreboot - Kyösti Mälkki [gmail.com] - 22 August 2017 23:35 EDT

SSFG was meant to be used as a mask to enable sleep states _S1 thru _S4. However as a logical instead of bitwise 'and' operation was used, all the states were enabled if only one was marked available.

State _S3 is now set conditionally if HAVE_ACPI_RESUME=y. For pi/hudson this had been fixed already preprocessor.

Note that all boards had SSFG == 0x0D that previously enabled ACPI S3 sleep state even when it was not available. States _S1 and _S2 still appear enabled in ASL/AML but may not actually work.

TEST: 'cat /sys/power/state' and notice choice 'mem' was removed from the list of available sleep states.

Change-Id: I27d616871c1771f0c87d8fba23d4ce1569607765

390ba04 AGESA binaryPI: Consolidate and fix sleep states
src/mainboard/amd/bettong/acpi/mainboard.asl | 2 --
src/mainboard/amd/bettong/dsdt.asl | 2 +-
src/mainboard/amd/db-ft3b-lc/acpi/mainboard.asl | 2 --
src/mainboard/amd/db-ft3b-lc/dsdt.asl | 2 +-
src/mainboard/amd/dinar/dsdt.asl | 25 ++-------------
src/mainboard/amd/inagua/acpi/mainboard.asl | 2 --
src/mainboard/amd/inagua/dsdt.asl | 2 +-
src/mainboard/amd/lamar/acpi/mainboard.asl | 2 --
src/mainboard/amd/lamar/dsdt.asl | 2 +-
src/mainboard/amd/olivehill/acpi/mainboard.asl | 2 --
src/mainboard/amd/olivehill/dsdt.asl | 2 +-
src/mainboard/amd/olivehillplus/acpi/mainboard.asl | 2 --
src/mainboard/amd/olivehillplus/dsdt.asl | 2 +-
src/mainboard/amd/parmer/acpi/mainboard.asl | 2 --
src/mainboard/amd/parmer/dsdt.asl | 2 +-
src/mainboard/amd/persimmon/acpi/mainboard.asl | 2 --
src/mainboard/amd/persimmon/dsdt.asl | 2 +-
src/mainboard/amd/south_station/acpi/mainboard.asl | 2 --
src/mainboard/amd/south_station/dsdt.asl | 2 +-
src/mainboard/amd/thatcher/acpi/mainboard.asl | 2 --
src/mainboard/amd/thatcher/dsdt.asl | 2 +-
src/mainboard/amd/torpedo/dsdt.asl | 25 ++-------------
src/mainboard/amd/union_station/acpi/mainboard.asl | 2 --
src/mainboard/amd/union_station/dsdt.asl | 2 +-
src/mainboard/asrock/e350m1/acpi/mainboard.asl | 2 --
src/mainboard/asrock/e350m1/dsdt.asl | 2 +-
src/mainboard/asrock/imb-a180/acpi/mainboard.asl | 2 --
src/mainboard/asrock/imb-a180/dsdt.asl | 2 +-
src/mainboard/asus/f2a85-m/acpi/mainboard.asl | 2 --
src/mainboard/asus/f2a85-m/dsdt.asl | 2 +-
src/mainboard/bap/ode_e20XX/acpi/mainboard.asl | 2 --
src/mainboard/bap/ode_e20XX/dsdt.asl | 2 +-
src/mainboard/bap/ode_e21XX/acpi/mainboard.asl | 2 --
src/mainboard/bap/ode_e21XX/dsdt.asl | 2 +-
src/mainboard/biostar/am1ml/acpi/mainboard.asl | 2 --
src/mainboard/biostar/am1ml/dsdt.asl | 2 +-
src/mainboard/elmex/pcm205400/acpi/mainboard.asl | 2 --
src/mainboard/elmex/pcm205400/dsdt.asl | 2 +-
src/mainboard/gizmosphere/gizmo/acpi/mainboard.asl | 2 --
src/mainboard/gizmosphere/gizmo/dsdt.asl | 2 +-
.../gizmosphere/gizmo2/acpi/mainboard.asl | 2 --
src/mainboard/gizmosphere/gizmo2/dsdt.asl | 2 +-
src/mainboard/hp/abm/acpi/mainboard.asl | 2 --
src/mainboard/hp/abm/dsdt.asl | 2 +-
.../hp/pavilion_m6_1035dx/acpi/mainboard.asl | 2 --
src/mainboard/hp/pavilion_m6_1035dx/dsdt.asl | 2 +-
.../jetway/nf81-t56n-lf/acpi/mainboard.asl | 2 --
src/mainboard/jetway/nf81-t56n-lf/dsdt.asl | 2 +-
src/mainboard/lenovo/g505s/acpi/mainboard.asl | 2 --
src/mainboard/lenovo/g505s/dsdt.asl | 2 +-
src/mainboard/lippert/frontrunner-af/dsdt.asl | 24 ++-------------
src/mainboard/lippert/toucan-af/dsdt.asl | 25 ++-------------
src/mainboard/msi/ms7721/acpi/mainboard.asl | 2 --
src/mainboard/msi/ms7721/dsdt.asl | 2 +-
src/mainboard/pcengines/apu1/acpi/mainboard.asl | 2 --
src/mainboard/pcengines/apu1/dsdt.asl | 2 +-
src/mainboard/pcengines/apu2/acpi/mainboard.asl | 2 --
src/mainboard/pcengines/apu2/dsdt.asl | 2 +-
src/mainboard/supermicro/h8qgi/dsdt.asl | 25 ++-------------
src/mainboard/supermicro/h8scm/dsdt.asl | 25 ++-------------
src/mainboard/tyan/s8226/dsdt.asl | 25 ++-------------
.../amd/agesa/hudson/acpi/sleepstates.asl | 36 ----------------------
.../amd/cimx/sb800/acpi/sleepstates.asl | 33 --------------------
.../amd/{pi/hudson => common}/acpi/sleepstates.asl | 20 ++++++------
64 files changed, 52 insertions(+), 319 deletions(-)

Upstream: review.coreboot.org


  • Share