cbmem: switch over to imd-based cbmem

Hardware / Coreboot - Aaron Durbin [chromium.org] - 22 April 2015 15:56 UTC

By design, the imd library still provdes dynamic growth so that feature is consistent. The imd-based cbmem packs small allocations into a larger entry using a tiered imd. The following examples show the reduced fragmentation and reduced memory usage.

Before with dynamic cbmem: CBMEM ROOT 0. 023ff000 00001000 aaaabbbb 1. 023fe000 00001000 aaaabbbc 2. 023fd000 00001000 aaaabbbe 3. 023fc000 00001000 aaaacccc 4. 023fa000 00002000 aaaacccd 5. 023f9000 00001000 ROMSTAGE 6. 023f8000 00001000 CONSOLE 7. 023d8000 00020000 COREBOOT 8. 023d6000 00002000

After with tiered imd: IMD ROOT 0. 023ff000 00001000 IMD SMALL 1. 023fe000 00001000 aaaacccc 2. 023fc000 00001060 aaaacccd 3. 023fb000 000007cf CONSOLE 4. 023db000 00020000 COREBOOT 5. 023d9000 00002000 IMD small region: IMD ROOT 0. 023fec00 00000400 aaaabbbb 1. 023febe0 00000020 aaaabbbc 2. 023feba0 00000040 aaaabbbe 3. 023feb20 00000080 ROMSTAGE 4. 023feb00 00000004

Side note: this CL provides a basis for what hoops one needs to jump through when there are not writeable global variables on a particular platform in the early stages.

Change-Id: If770246caa64b274819e45a26e100b62b9f8d2db

0dff57d cbmem: switch over to imd-based cbmem
src/include/cbmem.h | 13 --
src/lib/Makefile.inc | 7 +-
src/lib/cbmem_common.c | 46 ++---
src/lib/dynamic_cbmem.c | 470 -----------------------------------------------
src/lib/imd_cbmem.c | 294 +++++++++++++++++++++++++++++
util/cbmem/cbmem.c | 4 +
6 files changed, 321 insertions(+), 513 deletions(-)

Upstream: review.coreboot.org

  • Share