gsubprocess: Fix a critical calling communicate() with no pipes

Desktop / GNOME / GLib - Philip Withnall [endlessm.com] - 13 February 2018 16:27 EST

If calling g_subprocess_communicate() on a GSubprocess with no stdout/stderr pipe, a critical warning would be emitted from g_memory_output_stream_steal_as_bytes(), as it would be called on a NULL output stream.

Fix that, improve the relevant GIR annotations, and expand the unit tests to cover it (and various other combinations of flags).

66ab836f5 gsubprocess: Fix a critical calling communicate() with no pipes
gio/gsubprocess.c | 20 +++---
gio/tests/gsubprocess.c | 187 +++++++++++++++++++++++++++++++++++-------------
2 files changed, 149 insertions(+), 58 deletions(-)

Upstream: git.gnome.org


  • Share