kwin: Don't set the forward-compatible bit

Desktop / KDE / KDE Workspace - Fredrik Höglund [kde.org] - 7 August 2013 16:14 EDT

This flag seems to be ignored by several OpenGL implementations, so don't set it for now. Mesa may also stop accepting this flag until forward-compatible contexts are fully supported.

###

diff --git a/kwin/eglonxbackend.cpp b/kwin/eglonxbackend.cpp
index 9af3c0d..ab692d7 100644
--- a/kwin/eglonxbackend.cpp
+++ b/kwin/eglonxbackend.cpp
@@ -177,7 +177,6 @@ bool EglOnXBackend::initRenderingContext()
const EGLint context_attribs_31_core[] = {
EGL_CONTEXT_MAJOR_VERSION_KHR, 3,
EGL_CONTEXT_MINOR_VERSION_KHR, 1,
- EGL_CONTEXT_FLAGS_KHR, EGL_CONTEXT_OPENGL_FORWARD_COMPATIBLE_BIT_KHR,
EGL_NONE
};

diff --git a/kwin/glxbackend.cpp b/kwin/glxbackend.cpp
index 11f7017..545dedf 100644
--- a/kwin/glxbackend.cpp
+++ b/kwin/glxbackend.cpp
@@ -155,7 +155,7 @@ bool GlxBackend::initRenderingContext()
const int attribs_31_core_robustness[] = {
GLX_CONTEXT_MAJOR_VERSION_ARB, 3,
GLX_CONTEXT_MINOR_VERSION_ARB, 1,
- GLX_CONTEXT_FLAGS_ARB, GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB | GLX_CONTEXT_ROBUST_ACCESS_BIT_ARB,
+ GLX_CONTEXT_FLAGS_ARB, GLX_CONTEXT_ROBUST_ACCESS_BIT_ARB,
GLX_CONTEXT_RESET_NOTIFICATION_STRATEGY_ARB, GLX_LOSE_CONTEXT_ON_RESET_ARB,
0
};
@@ -163,7 +163,6 @@ bool GlxBackend::initRenderingContext()
const int attribs_31_core[] = {
GLX_CONTEXT_MAJOR_VERSION_ARB, 3,
GLX_CONTEXT_MINOR_VERSION_ARB, 1,
- GLX_CONTEXT_FLAGS_ARB, GLX_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB,
0
};

e06b43c kwin: Don't set the forward-compatible bit
kwin/eglonxbackend.cpp | 1 -
kwin/glxbackend.cpp | 3 +--
2 files changed, 1 insertion(+), 3 deletions(-)

Upstream: quickgit.kde.org


  • Share