Screenedge show support for Clients

Desktop / KDE / KDE Workspace - Martin Gräßlin [] - 26 February 2014 05:54 UTC

This provides a new protocol intended to be used by auto-hiding panels to make use of the centralized screen edges. To use it a Client can set an X11 property of type _KDE_NET_WM_SCREEN_EDGE_SHOW to KWin. As value it takes:
- 0: top edge
- 1: right edge
- 2: bottom edge
- 3: left edge

KWin will hide the Client (hide because unmap or minimize would break it) and create an Edge. If that Edge gets triggered the Client is shown again and the property gets deleted. If the Client doesn't border the specified screen edge the Client gets shown immediately so that we never end in a situation that we cannot unhide the auto-hidden panel again. The exact process is described in the documentation of ScreenEdges. The Client can request to be shown again by deleting the property.

If KWin gets restarted the state is read from the property and it is tried to create the edge as described.

As this is a KWin specific extension we need to discuss what it means for Clients using this feature with other WMs: it does nothing. As the Client gets hidden by KWin and not by the Client, it just doesn't get hidden if the WM doesn't provide the feature. In case of an auto-hiding panel this seems like a good solution given that we don't want to hide it if we cannot unhide it. Of course there's the option for the Client to provide that feature itself and if that's wanted we would need to announce the feature in the _NET_SUPPORTED atom. At the moment that doesn't sound like being needed as Plasma doesn't want to provide an own implementation.

The implementation comes with a small test application showing how the feature is intended to be used.

REVIEW: 115910

74e9869 Screenedge show support for Clients
kwin/atoms.cpp | 1 +
kwin/atoms.h | 1 +
kwin/client.cpp | 54 ++++++++++
kwin/client.h | 12 +++
kwin/events.cpp | 2 +
kwin/manage.cpp | 1 +
kwin/screenedge.cpp | 196 ++++++++++++++++++++++++++++++++++---
kwin/screenedge.h | 44 ++++++++-
kwin/tests/CMakeLists.txt | 5 +
kwin/tests/screenedgeshowtest.cpp | 98 +++++++++++++++++++
10 files changed, 399 insertions(+), 15 deletions(-)


  • Share