Enable -Wdeprecated-copy-dtor where available

Desktop / LibreOffice - Stephan Bergmann [redhat.com] - 12 December 2019 21:00 EST

We already get -Wdeprecated-copy (warning about implicitly defined copy functions that will in the future be deleted because other user-provided copy functions exist) automatically through -Wextra, where available.-Wdeprecated-copy-dtor (warning about implicitly defined copy functions that will in the future be deleted because of a user-provided dtor) is split off into its own warning excluded from -Wextra for somewhat unclear reasons, see the discussion at "-Wdeprecated-copy is draconian and shouldn't be in -Wall".

But -Wdeprecated-copy-dtor has been useful in finding issues (esp. the Clang 10 trunk version, which, unlike the GCC 9 version, also finds copy functions that are implicitly defined because they are used from template instantiations), see 3e59716375a240576fd6d8759b32b4319506ed70 "Prevent BroadcastRecalcOnRefMoveHandler copies" and 4f98cd0f9ce9c2a331a5d34b3ef9d18f9bb6b235 "ScShapeChild has broken copy functions".

We need to disable -Wdeprecated-copy-dtor in files included from external/boost, and in two compilerplugin/clang/test/ files.

Change-Id: I74b159c3a046e23661473ddbfe53c92c4136a9db Reviewed-on: https://gerrit.libreoffice.org/85073

e4fac1ebbdc7 Enable -Wdeprecated-copy-dtor where available
bin/gen-boost-headers | 1 +
compilerplugins/clang/test/commaoperator.cxx | 2 +-
compilerplugins/clang/test/unnecessaryoverride.cxx | 3 +++
config_host.mk.in | 1 +
configure.ac | 17 +++++++++++++++++
external/boost/include/boost/algorithm/string.hpp | 1 +
.../boost/include/boost/algorithm/string/case_conv.hpp | 1 +
.../include/boost/algorithm/string/classification.hpp | 1 +
.../boost/include/boost/algorithm/string/predicate.hpp | 1 +
external/boost/include/boost/algorithm/string/split.hpp | 1 +
external/boost/include/boost/any.hpp | 1 +
.../boost/archive/iterators/base64_from_binary.hpp | 1 +
.../boost/archive/iterators/binary_from_base64.hpp | 1 +
.../boost/archive/iterators/remove_whitespace.hpp | 1 +
.../include/boost/archive/iterators/transform_width.hpp | 1 +
external/boost/include/boost/asio.hpp | 1 +
external/boost/include/boost/assign.hpp | 1 +
external/boost/include/boost/bimap/bimap.hpp | 1 +
external/boost/include/boost/bimap/unordered_set_of.hpp | 1 +
external/boost/include/boost/bind.hpp | 1 +
external/boost/include/boost/cast.hpp | 1 +
external/boost/include/boost/circular_buffer.hpp | 1 +
external/boost/include/boost/config.hpp | 1 +
external/boost/include/boost/container/deque.hpp | 1 +
external/boost/include/boost/cstdint.hpp | 1 +
external/boost/include/boost/current_function.hpp | 1 +
external/boost/include/boost/date_time.hpp | 1 +
.../include/boost/date_time/posix_time/posix_time.hpp | 1 +
.../boost/include/boost/enable_shared_from_this.hpp | 1 +
.../include/boost/exception/diagnostic_information.hpp | 1 +
external/boost/include/boost/filesystem.hpp | 1 +
external/boost/include/boost/filesystem/path.hpp | 1 +
external/boost/include/boost/foreach.hpp | 1 +
external/boost/include/boost/format.hpp | 1 +
external/boost/include/boost/function.hpp | 1 +
external/boost/include/boost/functional/hash.hpp | 1 +
.../boost/include/boost/fusion/adapted/std_pair.hpp | 1 +
.../boost/include/boost/fusion/include/adapt_struct.hpp | 1 +
.../boost/intrusive/circular_list_algorithms.hpp | 1 +
external/boost/include/boost/intrusive_ptr.hpp | 1 +
external/boost/include/boost/io/ios_state.hpp | 1 +
.../include/boost/iostreams/device/file_descriptor.hpp | 1 +
external/boost/include/boost/iostreams/filter/gzip.hpp | 1 +
.../boost/include/boost/iostreams/filtering_stream.hpp | 1 +
.../boost/include/boost/iterator/iterator_facade.hpp | 1 +
external/boost/include/boost/lexical_cast.hpp | 1 +
external/boost/include/boost/locale.hpp | 1 +
external/boost/include/boost/locale/gnu_gettext.hpp | 1 +
external/boost/include/boost/logic/tribool.hpp | 1 +
external/boost/include/boost/make_shared.hpp | 1 +
external/boost/include/boost/math/common_factor_rt.hpp | 1 +
.../boost/include/boost/math/constants/constants.hpp | 1 +
.../include/boost/math/special_functions/expm1.hpp | 1 +
.../include/boost/math/special_functions/log1p.hpp | 1 +
.../boost/include/boost/math/special_functions/sinc.hpp | 1 +
external/boost/include/boost/multi_array.hpp | 1 +
.../boost/include/boost/multi_index/composite_key.hpp | 1 +
external/boost/include/boost/multi_index/identity.hpp | 1 +
external/boost/include/boost/multi_index/mem_fun.hpp | 1 +
.../boost/include/boost/multi_index/ordered_index.hpp | 1 +
.../include/boost/multi_index/random_access_index.hpp | 1 +
external/boost/include/boost/multi_index_container.hpp | 1 +
external/boost/include/boost/noncopyable.hpp | 1 +
external/boost/include/boost/none.hpp | 1 +
.../boost/include/boost/numeric/conversion/cast.hpp | 1 +
external/boost/include/boost/operators.hpp | 1 +
external/boost/include/boost/optional.hpp | 1 +
external/boost/include/boost/optional/optional.hpp | 1 +
external/boost/include/boost/preprocessor/stringize.hpp | 1 +
external/boost/include/boost/process/child.hpp | 1 +
external/boost/include/boost/program_options.hpp | 1 +
.../boost/include/boost/property_tree/json_parser.hpp | 1 +
external/boost/include/boost/property_tree/ptree.hpp | 1 +
.../boost/include/boost/ptr_container/ptr_vector.hpp | 1 +
external/boost/include/boost/range/adaptor/reversed.hpp | 1 +
external/boost/include/boost/range/iterator_range.hpp | 1 +
external/boost/include/boost/rational.hpp | 1 +
external/boost/include/boost/ref.hpp | 1 +
external/boost/include/boost/scoped_array.hpp | 1 +
external/boost/include/boost/scoped_ptr.hpp | 1 +
external/boost/include/boost/shared_array.hpp | 1 +
external/boost/include/boost/shared_ptr.hpp | 1 +
external/boost/include/boost/spirit.hpp | 1 +
external/boost/include/boost/spirit/include/classic.hpp | 1 +
.../boost/include/boost/spirit/include/classic_core.hpp | 1 +
.../boost/spirit/include/classic_error_handling.hpp | 1 +
.../boost/spirit/include/classic_file_iterator.hpp | 1 +
.../include/boost/spirit/include/classic_utility.hpp | 1 +
.../include/boost/spirit/include/classic_while.hpp | 1 +
external/boost/include/boost/spirit/include/phoenix.hpp | 1 +
external/boost/include/boost/spirit/include/qi.hpp | 1 +
external/boost/include/boost/spirit/include/qi_attr.hpp | 1 +
external/boost/include/boost/spirit/include/qi_lit.hpp | 1 +
.../boost/include/boost/spirit/include/qi_optional.hpp | 1 +
.../include/boost/spirit/include/qi_parse_attr.hpp | 1 +
.../boost/include/boost/spirit/include/qi_sequence.hpp | 1 +
.../boost/include/boost/spirit/include/qi_symbols.hpp | 1 +
external/boost/include/boost/static_assert.hpp | 1 +
external/boost/include/boost/system/error_code.hpp | 1 +
external/boost/include/boost/type_index.hpp | 1 +
external/boost/include/boost/unordered_map.hpp | 1 +
external/boost/include/boost/unordered_set.hpp | 1 +
external/boost/include/boost/uuid/uuid_generators.hpp | 1 +
external/boost/include/boost/uuid/uuid_io.hpp | 1 +
external/boost/include/boost/variant.hpp | 1 +
.../boost/include/boost/variant/recursive_variant.hpp | 1 +
external/boost/include/boost/version.hpp | 1 +
external/boost/include/boost/weak_ptr.hpp | 1 +
solenv/gbuild/platform/com_GCC_defs.mk | 4 ++++
109 files changed, 130 insertions(+), 1 deletion(-)

Upstream: cgit.freedesktop.org


  • Share