Extend loplugin:salbool to loplugin:fakebool

Desktop / LibreOffice - Stephan Bergmann [redhat.com] - 13 November 2019 14:06 EST

...checking for unnecessary uses of more "fake bool" types.

In the past, some of the checks involving the types of variables or data members, or the return types of functions, issued warnings that required surrounding code to be changed too (e.g., when changing the signature of a function whose address was taken). These checks have been tightened now to not warn in such cases (which avoids warnings that require changes to additional code, or changes that might even be impossible to make, at the cost of being less aggressive about removing all unnecessary uses of those "fake bool" types).

Change-Id: I70eb75039817cda34ed611387ee27dc5f36a3e2e Reviewed-on: https://gerrit.libreoffice.org/82554

913d34ec6b8f Extend loplugin:salbool to loplugin:fakebool
avmedia/source/gstreamer/gstplayer.cxx | 2 +-
.../clang/{salbool.cxx => fakebool.cxx} | 720 ++++++++++++++-------
.../clang/test/{salbool.cxx => fakebool.cxx} | 6 +-
connectivity/source/drivers/evoab2/NResultSet.cxx | 2 +-
.../source/drivers/jdbc/DatabaseMetaData.cxx | 8 +-
connectivity/source/drivers/jdbc/JStatement.cxx | 2 +-
connectivity/source/drivers/jdbc/Object.cxx | 4 +-
connectivity/source/drivers/jdbc/Reader.cxx | 2 +-
.../drivers/mysqlc/mysqlc_prepared_resultset.cxx | 4 +-
.../drivers/mysqlc/mysqlc_preparedstatement.cxx | 32 +-
.../drivers/mysqlc/mysqlc_preparedstatement.hxx | 4 +-
javaunohelper/source/javaunohelper.cxx | 2 +-
.../qa/gtktiledviewer/gtv-calc-header-bar.cxx | 2 +-
.../gtv-lokdocview-signal-handlers.cxx | 8 +-
libreofficekit/source/gtk/lokdocview.cxx | 32 +-
solenv/CompilerTest_compilerplugins_clang.mk | 2 +-
solenv/clang-format/blacklist | 4 +-
ucb/source/ucp/gio/gio_content.cxx | 2 +-
vcl/source/gdi/scrptrun.cxx | 2 +-
vcl/unx/gtk3/a11y/gtk3atklistener.cxx | 2 +-
vcl/unx/gtk3/fpicker/SalGtkFilePicker.cxx | 4 +-
vcl/unx/gtk3/gtk3gloactiongroup.cxx | 4 +-
vcl/unx/gtk3/gtk3glomenu.cxx | 2 +-
vcl/unx/gtk3/gtk3gtkdata.cxx | 2 +-
vcl/unx/gtk3/gtk3gtkframe.cxx | 8 +-
vcl/unx/gtk3/gtk3gtkinst.cxx | 16 +-
26 files changed, 553 insertions(+), 325 deletions(-)

Upstream: cgit.freedesktop.org


  • Share