improve and enable loplugin:fragiledestructor

Desktop / LibreOffice - Noel Grandin [collabora.co.uk] - 19 September 2019 09:42 EDT

Where the problem was benign and the class was not extended, I marked the class as final. Where the problem was benign and the class was extended, I marked the relevant callee methods as final.

Other cases were excluded in the plugin.

Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc Reviewed-on: https://gerrit.libreoffice.org/79089

82572caae4a2 improve and enable loplugin:fragiledestructor
bridges/source/cpp_uno/gcc3_linux_x86-64/rtti.cxx | 2 +-
compilerplugins/clang/fragiledestructor.cxx | 113 +++++++++++++--------
compilerplugins/clang/test/fragiledestructor.cxx | 88 ++++++++++++++++
connectivity/source/drivers/evoab2/NConnection.hxx | 2 +-
connectivity/source/drivers/evoab2/NResultSet.cxx | 4 +-
.../source/drivers/firebird/Connection.hxx | 2 +-
connectivity/source/inc/file/FConnection.hxx | 4 +-
connectivity/source/inc/file/FResultSet.hxx | 2 +-
connectivity/source/inc/odbc/OConnection.hxx | 4 +-
cppuhelper/source/weak.cxx | 2 +-
formula/source/core/api/token.cxx | 2 +-
include/oox/helper/binaryinputstream.hxx | 2 +-
include/oox/helper/binaryoutputstream.hxx | 2 +-
include/svx/fmgridif.hxx | 4 +-
sc/inc/chgtrack.hxx | 4 +-
sd/source/ui/inc/sdxfer.hxx | 2 +-
sd/source/ui/slideshow/slideshowimpl.hxx | 2 +-
solenv/CompilerTest_compilerplugins_clang.mk | 1 +
sw/inc/finalthreadmanager.hxx | 2 +-
sw/inc/section.hxx | 3 +-
ucb/source/ucp/file/filinpstr.hxx | 2 +-
ucb/source/ucp/gio/gio_inputstream.hxx | 2 +-
ucb/source/ucp/gio/gio_outputstream.hxx | 2 +-
vcl/inc/unx/gtk/gtkdata.hxx | 2 +-
vcl/inc/unx/salbmp.h | 2 +-
vcl/inc/unx/salframe.h | 2 +-
vcl/source/app/svdata.cxx | 2 +-
vcl/unx/generic/printer/printerinfomanager.cxx | 2 +-
vcl/unx/gtk3/gtk3gtkinst.cxx | 4 +-
vcl/workben/vcldemo.cxx | 2 +-
30 files changed, 193 insertions(+), 76 deletions(-)

Upstream: cgit.freedesktop.org


  • Share