Introduce gtk3_kde5 vcl plugin

Desktop / LibreOffice - Milian Wolff [kdab.com] - 23 January 2018 12:38 EST

This is a hybrid plugin which mostly wraps the GTK3 vclplug. Only the file and folder picker are replaced by KDE dialogs. This gives us a well-maintained GTK LO base with basic KDE integration with minimum effort.

To prevent issues with nested event loops, the KDE dialogs are launched from a separate process, the new lo_kde5filepicker helper executable. A trivial stdin/stdout IPC mechanism transfers the data between LO and the Qt/KDE helper. The usage of an external process also allows us to copy'n'paste between LO and the KDE file dialog without freezing the UI, as would happen when one would do this in-process. This is in general also the architecture applied by the kmozillahelper, which is used to integrate KDE file dialogs into Firefox.

While the KDE dialog is shown, the GTK3 main window is disabled and close requests are ignored. The KDE dialog in turn also sets the LO window as transient parent. Together, this makes the illusion perfect and the KDE dialog behaves like a modal dialog. This works properly also with multiple LO main windows, and only individual windows will get blocked as one would expect.

Functionality wise, most of the features of the KDE4 dialog are supported. You can pick files and folders, and save files under a new name. Some custom checkbox widgets are supported, but lists, buttons and preview widgets are not yet implemented. Also, loading remote files via KIO is not possible yet.

Change-Id: I1a97cf7c272307a19ace4222d5f12253bc722829 Reviewed-on: https://gerrit.libreoffice.org/47718

ecb5fcff336c Introduce gtk3_kde5 vcl plugin
Repository.mk | 6 +
config_host.mk.in | 1 +
config_host/config_gtk3_kde5.h.in | 10 +
config_host/config_vclplug.h.in | 1 +
configure.ac | 31 +-
vcl/CustomTarget_gtk3_kde5_moc.mk | 22 +
vcl/Executable_lo_kde5filepicker.mk | 99 +++++
vcl/Library_vclplug_gtk3_kde5.mk | 128 ++++++
vcl/Module_vcl.mk | 7 +
vcl/unx/generic/plugadapt/salplug.cxx | 5 +-
vcl/unx/gtk3_kde5/FPServiceInfo.hxx | 28 ++
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkaction.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkbridge.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkcomponent.cxx | 12 +
.../gtk3_kde5/a11y/gtk3_kde5_atkeditabletext.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkfactory.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkhypertext.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkimage.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atklistener.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkregistry.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkselection.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktable.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atktext.cxx | 12 +
.../gtk3_kde5/a11y/gtk3_kde5_atktextattributes.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkutil.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkvalue.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkwindow.cxx | 12 +
vcl/unx/gtk3_kde5/a11y/gtk3_kde5_atkwrapper.cxx | 12 +
vcl/unx/gtk3_kde5/filepicker_ipc_commands.hxx | 170 ++++++++
vcl/unx/gtk3_kde5/gtk3_kde5_a11y.cxx | 38 ++
vcl/unx/gtk3_kde5/gtk3_kde5_cairo.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.cxx | 456 +++++++++++++++++++++
vcl/unx/gtk3_kde5/gtk3_kde5_filepicker.hxx | 139 +++++++
vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.cxx | 201 +++++++++
vcl/unx/gtk3_kde5/gtk3_kde5_filepicker_ipc.hxx | 109 +++++
vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.cxx | 88 ++++
vcl/unx/gtk3_kde5/gtk3_kde5_folderpicker.hxx | 61 +++
vcl/unx/gtk3_kde5/gtk3_kde5_gloactiongroup.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_glomenu.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_gtkdata.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_gtkframe.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_gtkinst.cxx | 55 +++
vcl/unx/gtk3_kde5/gtk3_kde5_gtkobject.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_gtksalmenu.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_gtksys.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_hudawareness.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_printwrapper.cxx | 22 +
.../gtk3_kde5/gtk3_kde5_salnativewidgets-gtk.cxx | 22 +
vcl/unx/gtk3_kde5/gtk3_kde5_salprn-gtk.cxx | 22 +
vcl/unx/gtk3_kde5/kde5_filepicker.cxx | 283 +++++++++++++
vcl/unx/gtk3_kde5/kde5_filepicker.hxx | 113 +++++
vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx | 223 ++++++++++
vcl/unx/gtk3_kde5/kde5_filepicker_ipc.hxx | 45 ++
vcl/unx/gtk3_kde5/kde5_lo_filepicker_main.cxx | 39 ++
54 files changed, 2821 insertions(+), 5 deletions(-)

Upstream: cgit.freedesktop.org


  • Share