loplugin:external (clang-cl)

Desktop / LibreOffice - Stephan Bergmann [redhat.com] - 24 September 2018 15:22 EDT

Including:

- expanding STDAPI to its definition (as per "STDAPI"), to add __declspec(dllexport) into its middle, in extensions/source/activex/so_activex.cxx; as discussed in the comments at "Get rid of Windows .def files in setup_native, use __declspec(dllexport)", having a function both listed in a .def file EXPORTS and marking it dllexport is OK, and the latter helps the heuristics of loplugin:external; however, the relevant functions in extensions/source/activex/so_activex.cxx probably don't even need to be exported in the first place?

- follow-up loplugin:salcall in sal/osl/w32/file-impl.hxx

Change-Id: Ida6e17eba19cfa3d7e5c72dda57409005c0a0191 Reviewed-on: https://gerrit.libreoffice.org/60938

928b1b04adc1 loplugin:external (clang-cl)
avmedia/source/win/player.cxx | 2 +-
avmedia/source/win/window.cxx | 4 +-
bridges/source/cpp_uno/msvc_win32_x86-64/call.hxx | 32 +++++++++++++++
.../source/cpp_uno/msvc_win32_x86-64/cpp2uno.cxx | 3 +-
.../source/cpp_uno/msvc_win32_x86-64/except.cxx | 10 ++---
compilerplugins/clang/external.cxx | 46 +++++++++++++++++-----
dbaccess/win32/source/odbcconfig/odbcconfig.cxx | 6 +--
desktop/source/deployment/misc/dp_misc.cxx | 2 +-
desktop/win32/source/QuickStart/QuickStart.cxx | 4 +-
dtrans/source/win32/clipb/MtaOleClipb.cxx | 4 +-
dtrans/source/win32/dnd/dndentry.cxx | 4 +-
dtrans/source/win32/dnd/source.cxx | 2 +-
dtrans/source/win32/dtobj/FmtFilter.cxx | 12 +++---
dtrans/source/win32/dtobj/TxtCnvtHlp.cxx | 4 +-
embeddedobj/source/msole/olecomponent.cxx | 10 ++---
embeddedobj/source/msole/olepersist.cxx | 4 +-
embeddedobj/source/msole/xdialogcreator.cxx | 2 +-
embedserv/source/embed/docholder.cxx | 2 +-
embedserv/source/embed/ed_ipersiststr.cxx | 4 +-
embedserv/source/embed/register.cxx | 6 +--
embedserv/source/embed/servprov.cxx | 2 +-
embedserv/source/embed/tracker.cxx | 6 +--
embedserv/source/inprocserv/dllentry.cxx | 2 +
extensions/source/activex/SOActiveX.cxx | 7 ++--
extensions/source/activex/so_activex.cxx | 14 +++----
extensions/source/scanner/scanwin.cxx | 4 +-
fpicker/source/win32/FilterContainer.cxx | 2 +-
fpicker/source/win32/VistaFilePickerImpl.cxx | 10 ++---
fpicker/source/win32/WinImplHelper.cxx | 2 +-
fpicker/source/win32/resourceprovider.cxx | 2 +-
hwpfilter/source/grammar.cxx | 2 +-
idlc/source/options.cxx | 2 +-
jurt/source/pipe/wrapper/wrapper.c | 2 +-
jvmfwk/plugins/sunmajor/pluginlib/util.cxx | 8 ++--
odk/source/unoapploader/win/unoapploader.c | 10 ++---
pyuno/zipcore/python.cxx | 2 +-
sal/osl/w32/file-impl.hxx | 2 +-
sal/osl/w32/file.cxx | 1 +
sal/osl/w32/file_dirvol.cxx | 4 +-
sal/osl/w32/nlsupport.cxx | 4 +-
sal/osl/w32/pipe.cxx | 4 +-
sal/osl/w32/socket.cxx | 4 +-
sal/qa/osl/process/osl_process_child.cxx | 4 +-
.../indexingfilter/restartindexingservice.cxx | 4 +-
.../customactions/quickstarter/quickstarter.cxx | 2 +-
.../customactions/reg4allmsdoc/reg4allmsi.cxx | 4 +-
.../win32/customactions/regactivex/regactivex.cxx | 16 ++++----
.../source/win32/customactions/sellang/sellang.cxx | 6 +--
.../win32/customactions/tools/checkversion.cxx | 2 +-
sfx2/source/appl/appdde.cxx | 2 +-
sfx2/source/appl/shutdowniconw32.cxx | 10 ++---
shell/source/backends/localebe/localebackend.cxx | 2 +-
shell/source/tools/regsvrex/regsvrex.cxx | 2 +-
.../source/win32/ooofilereader/metainforeader.cxx | 2 +-
.../win32/shlxthandler/infotips/infotips.cxx | 8 ++--
.../source/win32/shlxthandler/ooofilt/ooofilt.cxx | 4 +-
shell/source/win32/shlxthandler/shlxthdl.cxx | 1 +
.../win32/shlxthandler/thumbviewer/thumbviewer.cxx | 6 +--
shell/source/win32/simplemail/senddoc.cxx | 20 +++++-----
shell/source/win32/spsupp/COMOpenDocuments.cxx | 4 +-
shell/source/win32/spsupp/spsuppServ.cxx | 2 +
smoketest/libtest.cxx | 4 +-
sw/source/ui/vba/vbasystem.cxx | 2 +-
vcl/opengl/win/gdiimpl.cxx | 8 ++--
vcl/win/app/salinst.cxx | 2 +-
vcl/win/gdi/gdiimpl.cxx | 10 ++---
vcl/win/gdi/salbmp.cxx | 2 +-
vcl/win/gdi/salfont.cxx | 14 +++----
vcl/win/gdi/salnativewidgets-luna.cxx | 8 ++--
vcl/win/gdi/salprn.cxx | 2 +-
vcl/win/window/salframe.cxx | 6 +--
vcl/win/window/salmenu.cxx | 2 +-
vcl/win/window/salobj.cxx | 12 +++---
winaccessibility/source/UAccCOM/MAccessible.cxx | 2 +-
.../source/service/msaaservice_impl.cxx | 2 +-
.../mscrypt/securityenvironment_mscryptimpl.cxx | 12 ++++--
.../xmlsec/mscrypt/x509certificate_mscryptimpl.cxx | 8 ++--
77 files changed, 265 insertions(+), 191 deletions(-)

Upstream: cgit.freedesktop.org


  • Share