loplugin:externvar is covered by loplugin:external

Desktop / LibreOffice - Stephan Bergmann [redhat.com] - 1 July 2020 17:50 UTC

...so drop the former. But keep the relevant externvar tests by moving them into compilerplugins/clang/test/external.cxx. (Which revealed one difference between the two plugins, regarding certain extern "C" variables in unnamed namespaces, where Clang (and for that matter also e.g. GCC, it appears) deliberately deviates from the Standard and considers them to have external linkage. Add clarifying comments that loplugin:external keeps considering these as having internal linkage, following the Standard.)

Change-Id: I344fcd0135fdaf6bf08a4b396af2ed2299389a7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97639

631cec87e2da loplugin:externvar is covered by loplugin:external
compilerplugins/clang/external.cxx | 13 ++-
compilerplugins/clang/externvar.cxx | 95 ----------------------
compilerplugins/clang/test/external.cxx | 70 ++++++++++++++++
.../clang/test/{externvar.hxx => external.hxx} | 7 +-
compilerplugins/clang/test/externvar.cxx | 61 --------------
solenv/CompilerTest_compilerplugins_clang.mk | 1 -
solenv/clang-format/blacklist | 4 +-
7 files changed, 84 insertions(+), 167 deletions(-)

Upstream: cgit.freedesktop.org


  • Share