loplugin:stringadd improve detection

Desktop / LibreOffice - Noel Grandin [collabora.co.uk] - 28 October 2019 11:07 EDT

if one side of the expression is a compile-time-constant, we don't need to worry about side-effects on the other side

Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b Reviewed-on: https://gerrit.libreoffice.org/81589

bc539bd3c049 loplugin:stringadd improve detection
codemaker/source/cppumaker/cppuoptions.cxx | 4 +-
codemaker/source/javamaker/javaoptions.cxx | 4 +-
comphelper/source/misc/backupfilehelper.cxx | 3 +-
compilerplugins/clang/stringadd.cxx | 59 +++++++++++------
compilerplugins/clang/test/stringadd.cxx | 16 ++---
cppu/source/uno/EnvStack.cxx | 3 +-
filter/source/msfilter/msdffimp.cxx | 4 +-
formula/source/ui/dlg/funcutl.cxx | 3 +-
idlc/source/options.cxx | 7 +-
io/source/acceptor/acc_socket.cxx | 8 +--
io/source/connector/ctr_socket.cxx | 8 +--
lotuswordpro/source/filter/lwptblformula.cxx | 6 +-
lotuswordpro/source/filter/xfilter/xfdrawpath.cxx | 6 +-
.../source/filter/xfilter/xfdrawpolygon.cxx | 6 +-
.../source/filter/xfilter/xfdrawpolyline.cxx | 6 +-
sal/qa/osl/file/osl_File.cxx | 18 +++---
sc/source/ui/unoobj/cellvaluebinding.cxx | 6 +-
sfx2/source/control/request.cxx | 4 +-
sot/source/sdstor/ucbstorage.cxx | 10 ++-
svl/qa/unit/svl.cxx | 4 +-
svx/source/dialog/hexcolorcontrol.cxx | 3 +-
svx/source/form/fmcontrollayout.cxx | 4 +-
svx/source/form/fmtextcontrolshell.cxx | 6 +-
svx/source/gallery2/galtheme.cxx | 4 +-
svx/source/svdraw/svdmrkv.cxx | 17 +++--
sw/qa/extras/layout/layout.cxx | 7 +-
sw/qa/extras/rtfexport/rtfexport2.cxx | 3 +-
sw/source/core/doc/dbgoutsw.cxx | 75 ++++++++++------------
sw/source/filter/html/htmlnumwriter.cxx | 3 +-
sw/source/filter/xml/xmltexte.cxx | 3 +-
sw/source/uibase/dbui/dbmgr.cxx | 22 +++----
ucb/source/ucp/ftp/ftpurl.cxx | 6 +-
writerfilter/source/dmapper/OLEHandler.cxx | 3 +-
xmlhelp/source/cxxhelp/provider/urlparameter.cxx | 10 +--
.../core/unointerfacetouniqueidentifiermapper.cxx | 3 +-
xmloff/source/draw/sdxmlexp.cxx | 4 +-
36 files changed, 177 insertions(+), 181 deletions(-)

Upstream: cgit.freedesktop.org


  • Share