make (some) clang plugins share the same RecursiveASTVisitor

Desktop / LibreOffice - Luboš Luňák [collabora.com] - 12 March 2019 11:36 EDT

Each plugin currently uses its own recursive AST run, which adds up. This patch adds another shared plugin which internally contains all (suitable) plugins and dispatches to them from the same one recursive run. This patch converts ~25 plugins and for starmath's accessibility.cxx reduces clang build time from 5.43s to 5.14s (and it's 4.39s without any plugins). As there are almost 50 more plugins to go, this can theoretically result in 4.56s final time, although probably not all plugins can be that easily converted, if at all.

This mostly requires very little change in many plugins (see e.g. BadStatics), some even work without any functionality change (e.g. CharRightShift). Traverse* calls require some changes but are often not that difficult. WalkUp* probably can't be supported, although some plugins can(?) possibly be adjusted to not rely on them. And of course some plugins can be left as they are, using their own recursive run. See description at the top of generator.cxx for description of how to convert a plugin.

The sharedvisitor.cxx source is generated based on scanning relevant plugin sources using a clang-based scanner/generator. The generated source is intentionally included instead of getting always generated, as the generating currently takes some time, so it should get updated in git whenever a change in a plugin triggers a source change in it.

Change-Id: Ia0d2e3a5a464659503dbb4ed6c20b6cc89b4de01 Reviewed-on: https://gerrit.libreoffice.org/68026

adb08e892b37 make (some) clang plugins share the same RecursiveASTVisitor
compilerplugins/Makefile-clang.mk | 48 +-
compilerplugins/clang/badstatics.cxx | 12 +-
compilerplugins/clang/blockblock.cxx | 17 +-
compilerplugins/clang/charrightshift.cxx | 6 +-
compilerplugins/clang/check.hxx | 2 +
compilerplugins/clang/datamembershadow.cxx | 6 +-
compilerplugins/clang/dbgunhandledexception.cxx | 38 +-
compilerplugins/clang/derefnullptr.cxx | 6 +-
compilerplugins/clang/doubleconvert.cxx | 6 +-
compilerplugins/clang/dyncastvisibility.cxx | 11 +-
compilerplugins/clang/empty.cxx | 6 +-
compilerplugins/clang/emptyif.cxx | 6 +-
compilerplugins/clang/externandnotdefined.cxx | 6 +-
compilerplugins/clang/externvar.cxx | 6 +-
compilerplugins/clang/inlinevisible.cxx | 6 +-
compilerplugins/clang/loopvartoosmall.cxx | 6 +-
compilerplugins/clang/plugin.cxx | 5 +-
compilerplugins/clang/plugin.hxx | 16 +-
compilerplugins/clang/pluginhandler.cxx | 25 +-
compilerplugins/clang/pluginhandler.hxx | 3 +-
compilerplugins/clang/privatebase.cxx | 6 +-
compilerplugins/clang/reservedid.cxx | 15 +-
compilerplugins/clang/sharedvisitor/generator.cxx | 563 ++++++++++++
.../clang/sharedvisitor/sharedvisitor.cxx | 964 +++++++++++++++++++++
compilerplugins/clang/simplifyconstruct.cxx | 10 +-
compilerplugins/clang/store/tutorial/tutorial1.cxx | 2 +-
compilerplugins/clang/store/tutorial/tutorial2.cxx | 2 +-
compilerplugins/clang/store/tutorial/tutorial3.cxx | 2 +-
compilerplugins/clang/stringstatic.cxx | 25 +-
compilerplugins/clang/subtlezeroinit.cxx | 15 +-
compilerplugins/clang/unnecessaryoverride.cxx | 33 +-
compilerplugins/clang/unnecessaryparen.cxx | 20 +-
compilerplugins/clang/unreffun.cxx | 24 +-
compilerplugins/clang/unusedvariablecheck.cxx | 6 +-
compilerplugins/clang/vclwidgets.cxx | 6 +-
compilerplugins/clang/weakobject.cxx | 11 +-
solenv/clang-format/blacklist | 2 +
37 files changed, 1862 insertions(+), 81 deletions(-)

Upstream: cgit.freedesktop.org


  • Share