new loplugin salcall: remove unnecessary SAL_CALL

Desktop / LibreOffice - Noel Grandin [collabora.co.uk] - 4 December 2017 06:24 EST

In this first commit, I use the plugin to verify the consistency of our SAL_CALL annotations. The point being to make the next commit more mechanical in nature, purely using the rewriter.

There are various chunks of unix-only code that have never had to be compiled by MSVC, hence the inconsistencies.

In bridges, I had to inline some typedefs to make the verification code happy, since it cannot see into typedefs.

Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0 Reviewed-on: https://gerrit.libreoffice.org/45502

68f86457525c new loplugin salcall: remove unnecessary SAL_CALL
bridges/inc/bridge.hxx | 17 +-
bridges/inc/cppinterfaceproxy.hxx | 3 +-
bridges/inc/unointerfaceproxy.hxx | 12 +-
compilerplugins/clang/salcall.cxx | 370 +++++++++++++++++++++
compilerplugins/clang/test/salcall.cxx | 104 ++++++
connectivity/source/drivers/odbc/ORealDriver.hxx | 2 +-
desktop/source/deployment/inc/dp_registry.hxx | 2 +-
extensions/source/propctrlr/eventhandler.hxx | 2 +-
.../source/propctrlr/genericpropertyhandler.hxx | 2 +-
extensions/source/scanner/scanunx.cxx | 4 +-
.../source/config/cache/contenthandlerfactory.hxx | 2 +-
filter/source/config/cache/filterfactory.hxx | 2 +-
filter/source/config/cache/frameloaderfactory.hxx | 2 +-
filter/source/config/cache/typedetection.hxx | 2 +-
filter/source/odfflatxml/OdfFlatXml.cxx | 2 +-
forms/source/xforms/binding.hxx | 2 +-
idlc/source/idlcproduce.cxx | 2 +-
include/formula/FormulaOpCodeMapperObj.hxx | 6 +-
sal/osl/unx/file.cxx | 2 +-
sd/source/ui/inc/facreg.hxx | 4 +-
solenv/CompilerTest_compilerplugins_clang.mk | 1 +
svtools/source/uno/fpicker.hxx | 4 +-
vcl/unx/generic/printer/printerinfomanager.cxx | 2 +-
vcl/unx/gtk/a11y/atklistener.hxx | 4 +-
vcl/unx/gtk/a11y/atkutil.cxx | 4 +-
.../source/xmlsec/nss/x509certificate_nssimpl.hxx | 2 +-
xmlsecurity/source/xmlsec/xsec_xmlsec.hxx | 2 +-
27 files changed, 513 insertions(+), 50 deletions(-)

Upstream: cgit.freedesktop.org


  • Share