Restore simple undo and redo buttons for the basctl module

Desktop / LibreOffice - Maxim Monastirsky [gmail.com] - 13 February 2020 20:21 EST

Changed in commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController"), but the dropdowns do not work in that module.

These buttons used to be managed by SvxSimpleUndoRedoController, but that's no longer the case. The reason is that ToolBarManager::CreateControllers checks first for controllers registered in Controller.xcu, and only if none found it checks for sfx2 controllers. So SvxSimpleUndoRedoController by using a sfx2-style registration, has no chance to be ever selected for .uno:Undo or .uno:Redo.

This commit removes the unused controller, and restores the previous behavior with the other controller.

Change-Id: Ia774195511e41ab11562856fe1cf2ec7f170710a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88606

98bc216781d5 Restore simple undo and redo buttons for the basctl module
basctl/source/basicide/basidesh.cxx | 3 ---
include/svx/tbcontrl.hxx | 14 --------------
svx/source/tbxctrls/lboxctrl.cxx | 2 +-
svx/source/tbxctrls/tbcontrl.cxx | 25 -------------------------
4 files changed, 1 insertion(+), 43 deletions(-)

Upstream: cgit.freedesktop.org


  • Share