tdf#94743: Web Wizard: Cannot export in ftp

Desktop / LibreOffice - Julien Nabet [yahoo.fr] - 4 October 2015 02:06 UTC

1) Fix value of constants RES_OK, RES_CANCEL and RES_HELP http://opengrok.libreoffice.org/xref/core/offapi/com/sun/star/awt/PushButtonType.idl#29

2) self.updatePublishUI was wrong because FTP appears in second but there are 2 elements for each module (local dir, zip, ftp) in pubAware vector comment was wrong:- local takes elements 0 and 1- zip takes elements 2 and 3- ftp takes elements 4 (that's why "4" is the right value) and 5 see http://opengrok.libreoffice.org/xref/core/wizards/com/sun/star/wizards/web/WWD_Startup.py#509 So fix value passed to self.updatePublishUI + comment

Just a bit of history: before fix of tdf#92934: Web Wizard: Cannot Export Zip archive (http://cgit.freedesktop.org/libreoffice/core/commit/?id=e72a4a3c2e1608e301daef0b6e87cc70d814e736), the order seemed to be this one for pubAware: local, ftp, zip (whereas UI order was already local, zip and ftp) Perhaps the fix was wrong since there was a similar pb for tdf#94421: Web Wizard, option shift when loading saved session

Anyway now the pubAware order is the same as UI order, it may help for readability.

minor a) increase space for lblStatus (there weren't enough room for some locales, eg French) b) replace use of copy3 (deprecated) by copy2

Change-Id: I27d3c2dd699fbe2d51a63e462c7b39e78895d1be Reviewed-on: https://gerrit.libreoffice.org/19115

e3f8eb8 tdf#94743: Web Wizard: Cannot export in ftp
wizards/com/sun/star/wizards/common/UCB.py | 2 +-
wizards/com/sun/star/wizards/web/FTPDialog.py | 8 ++++----
wizards/com/sun/star/wizards/web/WWD_Events.py | 2 +-
wizards/com/sun/star/wizards/web/WWD_Startup.py | 2 +-
4 files changed, 7 insertions(+), 7 deletions(-)

Upstream: cgit.freedesktop.org

  • Share