WIN enable osl_File.cxx part of CppUnitTest_sal_osl

Desktop / LibreOffice - Jan-Marek Glogowski [] - 3 December 2019 08:08 UTC

This just disables open::open_004 test on Windows, as this returns E_NOENT on Windows, but I think the assert is correct. There is also test-getsystempathfromfileurl.cxx, which seems to overlap?

The test now uses osl::FileBase::getTempDirURL to find the system temporary directory, insted of hardcoded defaults.

This also includes reverts the following commits:

- "remove unused Exist from oslCheckMode enum" commit 4ca9e8fa3a040c18221c947a651469a89029282e.
- "CppunitTest_sal_osl_file fails on Windows" commit 4603028bc4e2cdacd32da073a82a42ba1fc549a8

Change-Id: Ib7fc4c13f8159a240d4e20c26f61d84204e4261b Reviewed-on:

5a77636c9a63 WIN enable osl_File.cxx part of CppUnitTest_sal_osl
sal/ | 3 +-
sal/qa/osl/file/osl_File.cxx | 26 +++++++++------
sal/qa/osl/file/osl_File_Const.h | 68 ++++++++++++++++++++++++----------------
3 files changed, 60 insertions(+), 37 deletions(-)


  • Share