sh: add loglvl to dump_mem()

Linux Kernel / Linux Kernel - Dmitry Safonov [arista.com] - 9 June 2020 16:39 UTC

Currently, the log-level of show_stack() depends on a platform realization. It creates situations where the headers are printed with lower log level or higher than the stacktrace (depending on a platform or user).

Furthermore, it forces the logic decision from user to an architecture side. In result, some users as sysrq/kdb/etc are doing tricks with temporary rising console_loglevel while printing their messages. And in result it not only may print unwanted messages from other CPUs, but also omit printing at all in the unlucky case where the printk() was deferred.

Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier approach than introducing more printk buffers. Also, it will consolidate printings with headers.

Add log level argument to dump_mem() as a preparation to introduce show_stack_loglvl().

[1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u

ebf0a36a32b2 sh: add loglvl to dump_mem()
arch/sh/include/asm/kdebug.h | 3 ++-
arch/sh/kernel/dumpstack.c | 17 +++++++++--------
arch/sh/kernel/traps.c | 4 ++--
3 files changed, 13 insertions(+), 11 deletions(-)

Upstream: git.kernel.org


  • Share