sh: add loglvl to printk_address()

Linux Kernel / Linux Kernel - Dmitry Safonov [arista.com] - 9 June 2020 16:39 UTC

Currently, the log-level of show_stack() depends on a platform realization. It creates situations where the headers are printed with lower log level or higher than the stacktrace (depending on a platform or user).

Furthermore, it forces the logic decision from user to an architecture side. In result, some users as sysrq/kdb/etc are doing tricks with temporary rising console_loglevel while printing their messages. And in result it not only may print unwanted messages from other CPUs, but also omit printing at all in the unlucky case where the printk() was deferred.

Introducing log-level parameter and KERN_UNSUPPRESSED [1] seems an easier approach than introducing more printk buffers. Also, it will consolidate printings with headers.

Add log level argument to printk_address() as a preparation to introduce show_stack_loglvl().

As a good side-effect show_fault_oops() now prints the address with KERN_EMREG as the rest of output, making sure there won't be situation where "PC: " is printed without actual address.

[1]: https://lore.kernel.org/lkml/20190528002412.1625-1-dima@arista.com/T/#u

2deebe4d56d6 sh: add loglvl to printk_address()
arch/sh/include/asm/kdebug.h | 3 ++-
arch/sh/kernel/dumpstack.c | 6 +++---
arch/sh/mm/fault.c | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)

Upstream: git.kernel.org


  • Share