glsl: fail when a shader's input var has not an equivalent out var in previous

Graphics / Mesa 3D Graphics Library / Mesa - Samuel Iglesias Gonsalvez [igalia.com] - 30 March 2015 06:29 UTC

GLSL ES 3.00 spec, 4.3.10 (Linking of Vertex Outputs and Fragment Inputs), page 45 says the following:

"The type of vertex outputs and fragment input with the same name must match, otherwise the link command will fail. The precision does not need to match. Only those fragment inputs statically used (i.e. read) in the fragment shader must be declared as outputs in the vertex shader; declaring superfluous vertex shader outputs is permissible." [...] "The term static use means that after preprocessing the shader includes at least one statement that accesses the input or output, even if that statement is never actually executed."

And it includes a table with all the possibilities.

Similar table or content is present in other GLSL specs: GLSL 4.40, GLSL 1.50, etc but for more stages (vertex and geometry shaders, etc).

This patch detects that case and returns a link error. It fixes the following dEQP test:

dEQP-GLES3.functional.shaders.linkage.varying.rules.illegal_usage_1

However, it adds a new regression in piglit because the test hasn't a
vertex shader and it checks the link status.

bin/glslparsertest \ tests/spec/glsl-1.50/compiler/gs-also-uses-smooth-flat-noperspective.geom pass \ 1.50 --check-link

This piglit test is wrong according to the spec wording above, so if this patch is merged it should be updated.

18004c3 glsl: fail when a shader's input var has not an equivalent out var in previous
src/glsl/link_varyings.cpp | 13 +++++++++++++
1 file changed, 13 insertions(+)

Upstream: cgit.freedesktop.org

  • Share