i965: Make Gen4-5 SF_STATE use the point size calculations from Gen6+.

Graphics / Mesa 3D Graphics Library / Mesa - Kenneth Graunke [whitecape.org] - 14 June 2017 18:56 EDT

Apparently, Nanhai made the Gen4-5 point size calculations round to the nearest integer in commit 8d5231a3582e4f2769ac0685cf0174e09750700e, "according to spec". When Eric first ported the driver to Sandybridge, he did not implement this rounding.

In the GL 2.1 and 3.0 specs "Basic Point Rasterization" section, it does say "If antialiasing and point sprites are disabled, the actual width is determined by rounding the supplied width to the nearest integer, then clamping it to the implementation-dependent maximum non-antialised point width."

In contrast, GL 3.1 and later do not appear to contain this rounding.

It might be reasonable to round, given that we only implement GL 2.1. Of course, if we were to do that, we should actually implement the AA
vs. non-AA distinction. Brian added an XXX comment reminding us to fix this 10 years ago, but it never happened.

I think a better plan is to follow the newer, unrounded behavior. This is what we do on Gen6+ and it passes all the relevant conformance tests.

3d34e27 i965: Make Gen4-5 SF_STATE use the point size calculations from Gen6+.
src/mesa/drivers/dri/i965/brw_sf_state.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)

Upstream: cgit.freedesktop.org


  • Share