i965: Delete the meta-base CopyImageSubData implementation

Graphics / Mesa 3D Graphics Library / Mesa - Jason Ekstrand [intel.com] - 5 December 2016 16:00 UTC

When I originally implemented the ARB_copy_image extension, the fast-path was written in meta using texture views. This path only worked if both images were uncompressed color images. All of the other cases fell back to the blitter or, in the worst case, mapping and memcpy on the CPU. Now that we have the blorp path, it handles all copies ever and the old meta, blitter, and CPU paths are only used on gen5 and below. The primary reason why we needed the meta path (apart from having a slow blitter on later hardware) was to handle multisampling which gen5 and earlier don't support anyway. Since the blitter is reasonably fast on gen5, we can just delete the meta path and get rid of all that terrible code.

If we decide that we're ok with just disabling ARB_copy_image on gen5 and earlier (I personally am), then we could get rid of another 300 lines or so of semi-hairy code.

5f0e4c7 i965: Delete the meta-base CopyImageSubData implementation
src/mesa/Makefile.sources | 1 -
src/mesa/drivers/common/meta.h | 10 -
src/mesa/drivers/common/meta_copy_image.c | 307 --------------------------
src/mesa/drivers/dri/i965/intel_copy_image.c | 10 -
4 files changed, 328 deletions(-)

Upstream: cgit.freedesktop.org

  • Share