nir: Add a base const_index to shared atomic intrinsics

Graphics / Mesa 3D Graphics Library / Mesa - Kenneth Graunke [whitecape.org] - 21 July 2016 23:31 UTC

Commit 52e75dcb8c04c0dde989970c4c587cbe8313f7cf made nir_lower_io start using nir_intrinsic_set_base instead of writing const_index[0] directly. However, those intrinsics apparently don't /have/ a base, so this caused assert failures.

However, the old code was happily setting non-existent const_index fields, so it was pretty bogus too.

Jason pointed out that load_shared and store_shared have a base, and that the i965 driver uses that field. So presumably atomics should have one as well, so that loads/stores/atomics all refer to variables with consistent addressing.

Cc: "12.0"

cf6f2d3 nir: Add a base const_index to shared atomic intrinsics.
src/compiler/nir/nir_intrinsics.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

Upstream: cgit.freedesktop.org

  • Share