swr: invalidate attachment on transition change

Graphics / Mesa 3D Graphics Library / Mesa - George Kyriazis [intel.com] - 22 June 2017 12:51 EDT

Consider the following RT attachment order: 1. Attach surfaces attachments 0 & 1, and render with them 2. Detach 0 & 1 3. Re-attach 0 & 1 to different surfaces 4. Render with the new attachment

The definition of a tile being resolved is that local changes have been flushed out to the surface, hence there is no need to reload the tile before it's written to. For an invalid tile, the tile has to be reloaded from the surface before rendering.

Stage (2) was marking hot tiles for attachements 0 & 1 as RESOLVED, which means that the hot tiles can be written out to memory with no need to read them back in (they are "clean"). They need to be marked as resolved here, because a surface may be destroyed after a detach, and we don't want to have un-resolved tiles that may force a readback from a NULL (destroyed) surface. (Part of a destroy is detach all attachments first)

Stage (3), during the no att -> att transition, we need to realize that the "new" surface tiles need to be fetched fresh from the new surface, instead of using the resolved tiles, that belong to a stale attachment.

This is done by marking the hot tiles as invalid in stage (3), when we realize that a new attachment is being made, so that they are re-fetched during rendering in stage (4).

Also note that hot tiles are indexed by attachment.

- Fixes VTK dual depth-peeling tests.- No piglit changes

08cb8cf swr: invalidate attachment on transition change
src/gallium/drivers/swr/swr_draw.cpp | 19 +++++++++++++++++++
src/gallium/drivers/swr/swr_resource.h | 4 ++++
src/gallium/drivers/swr/swr_state.cpp | 5 +++++
3 files changed, 28 insertions(+)

Upstream: cgit.freedesktop.org


  • Share