auth-manager: always compile D-Bus calls to polkit

System Internals / NetworkManager - Thomas Haller [redhat.com] - 13 April 2018 07:09 EDT

Supporting PolicyKit required no additional library, just extra code to handle the D-Bus calls. For that, there was a compile time option to even stip out that code. Note, that you could (and still can) configure the system not to use policy-kit. The point was to reduce the binary size in case you don't need it.

Remove this. I guess, we we aim for such aggressive optimization of the binary size, we should instead make all device types disablable at configuration time. We don't do that either and other low hanging fruits, because it's better to always enable features, unless they require external dependencies.

Also, the next commit will make more use of NMAuthManager. So, having it disabled at compile time, makes even less sense.

41abf9f8e auth-manager: always compile D-Bus calls to polkit
config.h.meson | 3 ---
configure.ac | 26 ++++++++------------------
meson.build | 1 -
src/nm-auth-manager.c | 22 ----------------------
src/nm-auth-utils.c | 13 -------------
5 files changed, 8 insertions(+), 57 deletions(-)

Upstream: cgit.freedesktop.org


  • Share