device: fix order of params in nm_match_spec_device prototype

System Internals / NetworkManager - Olivier Gayot [sigexec.com] - 6 July 2018 12:48 EDT

The following commit:

b869d9cc0 device: add spec "driver:" to match devices

added two parameters ("driver" and "driver_version") to the nm_match_spec_device() function.

However, the definition of the function and its declaration are not consistent.

The prototype shows: nm_match_spec_device (const GSList *specs, const char *interface_name, const char *driver, const char *driver_version, const char *device_type,

But the definition shows: nm_match_spec_device (const GSList *specs, const char *interface_name, const char *device_type, const char *driver, const char *driver_version,

Since all parameters are pointers to const char, the type checking succeeds at compile time.

All currently existing invocations of the function are correct and pass the arguments in the order described in the definition/implementation. This patch only changes the prototype so that potential future invocations don't end up buggy.

Fixes: b869d9cc0dda4fe5300f5ec5b5a090199ecd4e3e

d1a98d689 device: fix order of params in nm_match_spec_device prototype
src/nm-core-utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Upstream: cgit.freedesktop.org


  • Share