wifi: always build nl80211 CRIT_PROTOCOL support

System Internals / NetworkManager - Thomas Haller [redhat.com] - 15 January 2018 19:29 EST

netlink's API is stable, and strictly defined by the integer values that make up commands and attributes. There is little reason do disable a netlink feature based on compile time detection of the kernel headers.

Either kernel supports it, or it will fail with an appropriate response.

Also, support for NL80211_CMD_CRIT_PROTOCOL_START was merge to kernel in 2013. Maybe, we should now just always assume support (in the kernel headers is there). Anyway, don't do that yet, but instead avoid the defines and use the numeric values directly.

a3f77b259 wifi: always build nl80211 CRIT_PROTOCOL support
config.h.meson | 3 ---
configure.ac | 24 ------------------------
meson.build | 16 ----------------
src/platform/nm-fake-platform.c | 1 -
src/platform/wifi/wifi-utils-nl80211.c | 17 +++++++++--------
5 files changed, 9 insertions(+), 52 deletions(-)

Upstream: cgit.freedesktop.org


  • Share