Add safeguards in LSN, numeric and float calculation for custom errors

Enterprise / PostgreSQL - Michael Paquier [paquier.xyz] - 5 August 2019 06:35 EDT

Those data types use parsing and/or calculation wrapper routines which can generate some generic error messages in the event of a failure. The caller of these routines can also pass a pointer variable settable by the routine to track if an error has happened, letting the caller decide what to do in the event of an error and what error message to generate.

Those routines have been slacking the initialization of the tracking flag, which can be confusing when reading the code, so add some safeguards against calls of these parsing routines which could lead to a dubious result.

The LSN parsing gains an assertion to make sure that the tracking flag is set, while numeric and float paths initialize the flag to a saner state.

Author: Jeevan Ladhe

a76cfba663 Add safeguards in LSN, numeric and float calculation for custom errors
src/backend/utils/adt/float.c | 20 +++++++++++++-------
src/backend/utils/adt/numeric.c | 12 ++++++++++++
src/backend/utils/adt/pg_lsn.c | 3 +++
3 files changed, 28 insertions(+), 7 deletions(-)

Upstream: git.postgresql.org


  • Share