Add support for partitioned tables and indexes in REINDEX

Enterprise / PostgreSQL - Michael Paquier [paquier.xyz] - 8 September 2020 01:09 UTC

Until now, REINDEX was not able to work with partitioned tables and indexes, forcing users to reindex partitions one by one. This extends REINDEX INDEX and REINDEX TABLE so as they can accept a partitioned index and table in input, respectively, to reindex all the partitions assigned to them with physical storage (foreign tables, partitioned tables and indexes are then discarded).

This shares some logic with schema and database REINDEX as each partition gets processed in its own transaction after building a list of relations to work on. This choice has the advantage to minimize the number of invalid indexes to one partition with REINDEX CONCURRENTLY in the event a cancellation or failure in-flight, as the only indexes handled at once in a single REINDEX CONCURRENTLY loop are the ones from the partition being working on.

Isolation tests are added to emulate some cases I bumped into while developing this feature, particularly with the concurrent drop of a leaf partition reindexed. However, this is rather limited as LOCK would cause REINDEX to block in the first transaction building the list of partitions.

Per its multi-transaction nature, this new flavor cannot run in a transaction block, similarly to REINDEX SCHEMA, SYSTEM and DATABASE.

Author: Justin Pryzby, Michael Paquier

a6642b3ae0 Add support for partitioned tables and indexes in REINDEX
contrib/postgres_fdw/expected/postgres_fdw.out | 21 ++
contrib/postgres_fdw/sql/postgres_fdw.sql | 20 ++
doc/src/sgml/ref/reindex.sgml | 13 +-
src/backend/catalog/index.c | 25 +--
src/backend/commands/indexcmds.c | 245 ++++++++++++++++-----
src/backend/tcop/utility.c | 6 +-
src/include/commands/defrem.h | 4 +-
src/test/isolation/expected/reindex-partitions.out | 107 +++++++++
src/test/isolation/isolation_schedule | 1 +
src/test/isolation/specs/reindex-partitions.spec | 59 +++++
src/test/regress/expected/create_index.out | 158 ++++++++++++-
src/test/regress/sql/create_index.sql | 88 +++++++-
src/tools/pgindent/typedefs.list | 1 +
13 files changed, 656 insertions(+), 92 deletions(-)

Upstream: git.postgresql.org


  • Share