Add text-vs-name cross-type operators, and unify name_ops with text_ops

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 19 December 2018 22:46 EST

Now that name comparison has effectively the same behavior as text comparison, we might as well merge the name_ops opfamily into text_ops, allowing cross-type comparisons to be processed without forcing a datatype coercion first. We need do little more than add cross-type operators to make the opfamily complete, and fix one or two places in the planner that assumed text_ops was a single-datatype opfamily.

I chose to unify hash name_ops into hash text_ops as well, since the types have compatible hashing semantics. This allows marking the new cross-type equality operators as oprcanhash.

(Note: this doesn't remove the name_ops opclasses, so there's no breakage of index definitions. Those opclasses are just reparented into the text_ops opfamily.)

Discussion: https://postgr.es/m/15938.1544377821@sss.pgh.pa.us

2ece7c07dc Add text-vs-name cross-type operators, and unify name_ops with text_ops.
src/backend/optimizer/path/indxpath.c | 36 +++----
src/backend/utils/adt/selfuncs.c | 4 +-
src/backend/utils/adt/varlena.c | 161 +++++++++++++++++++++++++++++
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_amop.dat | 69 +++++++++----
src/include/catalog/pg_amproc.dat | 20 ++--
src/include/catalog/pg_opclass.dat | 4 +-
src/include/catalog/pg_operator.dat | 59 +++++++++++
src/include/catalog/pg_opfamily.dat | 4 -
src/include/catalog/pg_proc.dat | 43 ++++++++
src/test/regress/expected/opr_sanity.out | 14 +++
src/test/regress/expected/regex.out | 14 +--
src/test/regress/expected/select_views.out | 40 +++----
13 files changed, 385 insertions(+), 85 deletions(-)

Upstream: git.postgresql.org


  • Share