Add a default local latch for use in signal handlers

Enterprise / PostgreSQL - Andres Freund [anarazel.de] - 14 January 2015 11:45 UTC

To do so, move InitializeLatchSupport() into the new common process initialization functions, and add a new global variable MyLatch.

MyLatch is usable as soon InitPostmasterChild() has been called (i.e. very early during startup). Initially it points to a process local latch that exists in all processes. InitProcess/InitAuxiliaryProcess then replaces that local latch with PGPROC->procLatch. During shutdown the reverse happens.

This is primarily advantageous for two reasons: For one it simplifies dealing with the shared process latch, especially in signal handlers, because instead of having to check for MyProc, MyLatch can be used unconditionally. For another, a later patch that makes FEs/BE communication use latches, now can rely on the existence of a latch, even before having gone through InitProcess.

Discussion: 20140927191243.GD5423@alap3.anarazel.de

59f71a0 Add a default local latch for use in signal handlers.
src/backend/postmaster/autovacuum.c | 13 ++++-----
src/backend/postmaster/bgworker.c | 4 +--
src/backend/postmaster/bgwriter.c | 12 ++++-----
src/backend/postmaster/checkpointer.c | 13 ++++-----
src/backend/postmaster/pgarch.c | 21 +++++----------
src/backend/postmaster/pgstat.c | 19 +++++---------
src/backend/postmaster/syslogger.c | 21 +++++----------
src/backend/postmaster/walwriter.c | 10 +++----
src/backend/replication/syncrep.c | 4 +--
src/backend/storage/ipc/procsignal.c | 4 +--
src/backend/storage/ipc/shm_mq.c | 12 ++++-----
src/backend/storage/lmgr/proc.c | 42 +++++++++++++-----------------
src/backend/tcop/postgres.c | 12 +++------
src/backend/utils/adt/misc.c | 4 +--
src/backend/utils/init/globals.c | 9 +++++++
src/backend/utils/init/miscinit.c | 37 ++++++++++++++++++++++++++
src/backend/utils/misc/timeout.c | 6 ++---
src/include/miscadmin.h | 4 +++
src/include/storage/latch.h | 2 +-
src/test/modules/test_shm_mq/setup.c | 4 +--
src/test/modules/test_shm_mq/test.c | 4 +--
src/test/modules/test_shm_mq/worker.c | 3 +--
src/test/modules/worker_spi/worker_spi.c | 10 +++----
23 files changed, 136 insertions(+), 134 deletions(-)

Upstream: git.postgresql.org

  • Share