Avoid locale-dependent output in select_views regression test

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 28 May 2017 14:52 EDT

Use 'COLLATE "C"' to force locale-independent sorting of the iexit
view results in select_views.sql. We aren't particularly interested in the exact sorting behavior here, and this doesn't change the shape of the generated plan, so it seems like a wash as far as the goals of this test go.

This is in response to bug #14637 from Tomasz Kontusz. It doesn't fully resolve his problem, because he also saw some diffs in the create_index test. But other people have had issues with select_views too, and this fix lets us drop the select_views_1.out variant expected file altogether, which is a nice win from a maintenance standpoint.

Emre Hasegeli

Discussion: https://postgr.es/m/20170501000609.24360.24248@wrigleys.postgresql.org

eac0a6c Avoid locale-dependent output in select_views regression test.
src/test/regress/expected/select_views.out | 2 +-
src/test/regress/expected/select_views_1.out | 1552 --------------------------
src/test/regress/sql/select_views.sql | 2 +-
3 files changed, 2 insertions(+), 1554 deletions(-)

Upstream: git.postgresql.org

  • Share