Avoid transferring parallel-unsafe subplans to parallel workers

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 12 April 2017 16:07 EDT

Commit 5e6d8d2bb allowed parallel workers to execute parallel-safe subplans, but it transmitted the query's entire list of subplans to the worker(s). Since execMain.c blindly does ExecInitNode and later ExecEndNode on every list element, this resulted in parallel-unsafe plan nodes nonetheless getting started up and shut down in parallel workers. That seems mostly harmless as far as core plan node types go (but maybe not so much for Gather?). But it resulted in postgres_fdw opening and then closing extra remote connections, and it's likely that other non-parallel-safe FDWs or custom scan providers would have worse reactions.

To fix, just make ExecSerializePlan replace parallel-unsafe subplans with NULLs in the cut-down plan tree that it transmits to workers. This relies on ExecInitNode and ExecEndNode to do nothing on NULL input, but they do anyway. If anything else is touching the dropped subplans in a parallel worker, that would be a bug to be fixed. (This thus provides a strong guarantee that we won't try to do something with a parallel-unsafe subplan in a worker.)

This is, I think, the last fix directly occasioned by Andreas Seltenreich's bug report of a few days ago.

Tom Lane and Amit Kapila

Discussion: https://postgr.es/m/87tw5x4vcu.fsf@credativ.de

16ebab6 Avoid transferring parallel-unsafe subplans to parallel workers.
src/backend/executor/execParallel.c | 25 +++++++++++++++++++++----
src/include/nodes/plannodes.h | 3 ++-
2 files changed, 23 insertions(+), 5 deletions(-)

Upstream: git.postgresql.org

  • Share