Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)

Enterprise / PostgreSQL - Alvaro Herrera [alvh.no-ip.org] - 5 March 2018 22:37 EST

The LIKE INCLUDING ALL clause to CREATE TABLE intuitively indicates cloning of extended statistics on the source table, but it failed to do so. Patch it up so that it does. Also include an INCLUDING STATISTICS option to the LIKE clause, so that the behavior can be requested individually, or excluded individually.

While at it, reorder the INCLUDING options, both in code and in docs, in alphabetical order which makes more sense than feature-implementation order that was previously used.

Backpatch this to Postgres 10, where extended statistics were introduced, because this is seen as an oversight in a fresh feature which is better to get consistent from the get-go instead of changing only in pg11.

In pg11, comments on statistics objects are cloned too. In pg10 they are not, because I (Álvaro) was too coward to change the parse node as required to support it. Also, in pg10 I chose not to renumber the parser symbols for the various INCLUDING options in LIKE, for the same reason. Any corresponding user-visible changes (docs) are backpatched, though.

5564c11815 Clone extended stats in CREATE TABLE (LIKE INCLUDING ALL)
doc/src/sgml/ref/create_table.sgml | 8 +-
src/backend/commands/indexcmds.c | 5 +-
src/backend/commands/statscmds.c | 169 ++++++++++++++++++++----
src/backend/nodes/copyfuncs.c | 1 +
src/backend/nodes/equalfuncs.c | 1 +
src/backend/nodes/outfuncs.c | 1 +
src/backend/parser/gram.y | 7 +-
src/backend/parser/parse_utilcmd.c | 143 ++++++++++++++++++++
src/include/nodes/parsenodes.h | 12 +-
src/test/regress/expected/create_table_like.out | 10 ++
src/test/regress/sql/create_table_like.sql | 3 +
11 files changed, 323 insertions(+), 37 deletions(-)

Upstream: git.postgresql.org


  • Share