Code review focused on new node types added by partitioning support

Enterprise / PostgreSQL - Tom Lane [] - 28 May 2017 23:20 EDT

Fix failure to check that we got a plain Const from const-simplification of a coercion request. This is the cause of bug #14666 from Tian Bing: there is an int4 to money cast, but it's only stable not immutable (because of dependence on lc_monetary), resulting in a FuncExpr that the code was miserably unequipped to deal with, or indeed even to notice that it was failing to deal with. Add test cases around this coercion behavior.

In view of the above, sprinkle the code liberally with castNode() macros, in hope of catching the next such bug a bit sooner. Also, change some functions that were randomly declared to take Node* to take more specific pointer types. And change some struct fields that were declared Node* but could be given more specific types, allowing removal of assorted explicit casts.

Place PARTITION_MAX_KEYS check a bit closer to the code it's protecting. Likewise check only-one-key-for-list-partitioning restriction in a less random place.

Avoid not-per-project-style usages like !strcmp(...).

Fix assorted failures to avoid scribbling on the input of parse transformation. I'm not sure how necessary this is, but it's entirely silly for these functions to be expending cycles to avoid that and not getting it right.

Add guards against partitioning on system columns.

Put backend/nodes/ support code into an order that matches handling of these node types elsewhere.

Annotate the fact that somebody added location fields to PartitionBoundSpec and PartitionRangeDatum but forgot to handle them in outfuncs.c/readfuncs.c. This is fairly harmless for production purposes (since readfuncs.c would just substitute -1 anyway) but it's still bogus. It's not worth forcing a post-beta1 initdb just to fix this, but if we have another reason to force initdb before 10.0, we should go back and clean this up.

Contrariwise, somebody added location fields to PartitionElem and PartitionSpec but forgot to teach exprLocation() about them.

Consolidate duplicative code in transformPartitionBound().

Improve a couple of error messages.

Improve assorted commentary.

Re-pgindent the files touched by this patch; this affects a few comment blocks that must have been added quite recently.


76a3df6 Code review focused on new node types added by partitioning support.
src/backend/catalog/heap.c | 2 +-
src/backend/catalog/partition.c | 64 +++++----
src/backend/commands/tablecmds.c | 90 ++++++++----
src/backend/nodes/copyfuncs.c | 30 ++--
src/backend/nodes/equalfuncs.c | 22 +--
src/backend/nodes/nodeFuncs.c | 6 +
src/backend/nodes/outfuncs.c | 28 ++--
src/backend/nodes/readfuncs.c | 4 +
src/backend/parser/gram.y | 29 ++--
src/backend/parser/parse_utilcmd.c | 223 ++++++++++++++---------------
src/backend/utils/adt/ruleutils.c | 28 ++--
src/include/catalog/heap.h | 3 +-
src/include/catalog/partition.h | 6 +-
src/include/nodes/nodes.h | 2 +-
src/include/nodes/parsenodes.h | 48 ++++---
src/include/parser/parse_utilcmd.h | 4 +-
src/test/regress/expected/create_table.out | 25 +++-
src/test/regress/sql/create_table.sql | 17 +++
18 files changed, 361 insertions(+), 270 deletions(-)


  • Share