Convert PageAddItem into a macro to save a few cycles

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 9 September 2016 17:17 UTC

Nowadays this is just a backwards-compatibility wrapper around PageAddItemExtended, so let's avoid the extra level of function call. In addition, because pretty much all callers are passing constants for the two bool arguments, compilers will be able to constant-fold the conversion to a flags bitmask.

Discussion: <552.1473445163@sss.pgh.pa.us>

1a4be10 Convert PageAddItem into a macro to save a few cycles.
src/backend/storage/page/bufpage.c | 20 --------------------
src/include/storage/bufpage.h | 7 +++++--
2 files changed, 5 insertions(+), 22 deletions(-)

Upstream: git.postgresql.org

  • Share