Fix misbehavior with expression indexes on ON COMMIT DELETE ROWS tables

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 1 December 2019 18:09 EST

We implement ON COMMIT DELETE ROWS by truncating tables marked that way, which requires also truncating/rebuilding their indexes. But RelationTruncateIndexes asks the relcache for up-to-date copies of any index expressions, which may cause execution of eval_const_expressions on them, which can result in actual execution of subexpressions. This is a bad thing to have happening during ON COMMIT. Manuel Rigger reported that use of a SQL function resulted in crashes due to expectations that ActiveSnapshot would be set, which it isn't. The most obvious fix perhaps would be to push a snapshot during PreCommit_on_commit_actions, but I think that would just open the door to more problems: CommitTransaction explicitly expects that no user-defined code can be running at this point.

Fortunately, since we know that no tuples exist to be indexed, there seems no need to use the real index expressions or predicates during RelationTruncateIndexes. We can set up dummy index expressions instead (we do need something that will expose the right data type, as there are places that build index tupdescs based on this), and just ignore predicates and exclusion constraints.

In a green field it'd likely be better to reimplement ON COMMIT DELETE ROWS using the same "init fork" infrastructure used for unlogged relations. That seems impractical without catalog changes though, and even without that it'd be too big a change to back-patch. So for now do it like this.

Per private report from Manuel Rigger. This has been broken forever, so back-patch to all supported branches.

c35b714caf Fix misbehavior with expression indexes on ON COMMIT DELETE ROWS tables.
src/backend/catalog/heap.c | 11 ++++++--
src/backend/catalog/index.c | 50 +++++++++++++++++++++++++++++++++++++
src/backend/utils/cache/relcache.c | 51 ++++++++++++++++++++++++++++++++++++++
src/include/catalog/index.h | 2 ++
src/include/utils/relcache.h | 1 +
src/test/regress/expected/temp.out | 2 ++
src/test/regress/sql/temp.sql | 3 +++
7 files changed, 118 insertions(+), 2 deletions(-)

Upstream: git.postgresql.org


  • Share