Improve error cursor positions for problems with partition bounds

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 23 September 2020 22:04 UTC

We failed to pass down the query string to check_new_partition_bound, so that its attempts to provide error cursor positions were for naught; one must have the query string to get parser_errposition to do anything. Adjust its API to require a ParseState to be passed down.

Also, improve the logic inside check_new_partition_bound so that the cursor points at the partition bound for the specific column causing the issue, when one can be identified.

That part is also for naught if we can't determine the query position of the column with the problem. Improve transformPartitionBoundValue so that it makes sure that const-simplified partition expressions will be properly labeled with positions. In passing, skip calling evaluate_expr if the value is already a Const, which is surely the most common case.

Alexandra Wang, Ashwin Agrawal, Amit Langote; reviewed by Ashutosh Bapat

Discussion: https://postgr.es/m/CACiyaSopZoqssfMzgHk6fAkp01cL6vnqBdmTw2C5_KJaFR_aMg@mail.gmail.com Discussion: https://postgr.es/m/CAJV4CdrZ5mKuaEsRSbLf2URQ3h6iMtKD=hik8MaF5WwdmC9uZw@mail.gmail.com

6b2c4e59d0 Improve error cursor positions for problems with partition bounds.
src/backend/commands/tablecmds.c | 16 +++--
src/backend/parser/parse_utilcmd.c | 53 ++++++++++-----
src/backend/partitioning/partbounds.c | 101 +++++++++++++++++++----------
src/include/partitioning/partbounds.h | 8 +--
src/test/regress/expected/alter_table.out | 10 +++
src/test/regress/expected/create_table.out | 30 +++++++++
6 files changed, 160 insertions(+), 58 deletions(-)

Upstream: git.postgresql.org


  • Share