On macOS, use -isysroot in link steps as well as compile steps

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 20 November 2020 05:07 UTC

We previously put the -isysroot switch only into CPPFLAGS, theorizing that it was only needed to find the right copies of include files. However, it seems that we also need to use it while linking programs, to find the right stub ".tbd" files for libraries. We got away without that up to now, but apparently that was mostly luck. It may also be that failures are only observed when the Xcode version is noticeably out of sync with the host macOS version; the case that's prompting action right now is that builds fail when using latest Xcode (12.2) on macOS Catalina, even though it's fine on Big Sur.

Hence, add -isysroot to LDFLAGS as well. (It seems that the more common practice is to put it in CFLAGS, whence it'd be included at both compile and link steps. However, we can't mess with CFLAGS in the platform template file without confusing configure's logic for choosing default CFLAGS.)

This should be back-patched, but first let's see if the buildfarm likes it on HEAD.

Report and patch by James Hilliard (some cosmetic mods by me)

Discussion: https://postgr.es/m/20201120003314.20560-1-james.hilliard1@gmail.com

49407dc32a On macOS, use -isysroot in link steps as well as compile steps.
configure | 2 ++
configure.ac | 2 ++
src/template/darwin | 1 +
3 files changed, 5 insertions(+)

Upstream: git.postgresql.org


  • Share