On Windows, make pg_dump use binary mode for compressed plain text output

Enterprise / PostgreSQL - Tom Lane [sss.pgh.pa.us] - 19 June 2017 11:02 EDT

The combination of -Z -Fp and output to stdout resulted in corrupted output data, because we left stdout in text mode, resulting in newline conversion being done on the compressed stream. Switch stdout to binary mode for this case, at the same place where we do it for non-text output formats.

Report and patch by Kuntal Ghosh, tested by Ashutosh Sharma and Neha Sharma. Back-patch to all supported branches.

Discussion: https://postgr.es/m/CAGz5QCJPvbBjXAmJuGx1B_41yVCetAJhp7rtaDf7XQGWuB1GSw@mail.gmail.com

bd61d5a On Windows, make pg_dump use binary mode for compressed plain text output.
src/bin/pg_dump/pg_backup_archiver.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

Upstream: git.postgresql.org


  • Share