test-daemon: No need to define dl-search-path

System Internals / PulseAudio - Arnaud Rebillout [collabora.com] - 8 June 2019 09:57 EDT

There's already a hook that modifies the search path when run from the build tree.

if (pa_run_from_build_tree()) { pa_log_notice("Detected that we are run from the build tree, fixing search path."); #ifdef MESON_BUILD c->dl_search_path = pa_xstrdup(PA_BUILDDIR PA_PATH_SEP "src" PA_PATH_SEP "modules"); #else c->dl_search_path = pa_xstrdup(PA_BUILDDIR); #endif } else

I'm not sure how it works behind the hood, but by setting--dl-search-path, we get errors in the logs when running `make check-daemon`:

E: [pulseaudio][daemon/ltdl-bind-now.c:75 bind_now_open()] Failed to open module /home/arno/proj/pulse/src/pa.up/src/.libs/.libs/module-native-protocol-unix.so: /home/arno/proj/pulse/src/pa.up/src/.libs/.libs/module-native-protocol-unix.so: cannot open shared object file: No such file or directory I: [pulseaudio][pulsecore/module.c:197 pa_module_load()] Loaded "module-native-protocol-unix" (index: #3; argument: "").

So basically, PA tries two paths, fails the first time (obviously we can see the path is not correct), then tries again with another path (where does it gets it?) and succeeds. So there's no obvious error if you don't look at the log.

This commit removes the useless `--dl-search-path`, which has the effect to remove the errors in the logs.

a37046cc3 test-daemon: No need to define dl-search-path
src/tests/test-daemon.sh | 1 -
1 file changed, 1 deletion(-)

Upstream: cgit.freedesktop.org


  • Share