monitor: Make client_migrate_info synchronous

Enterprise / Virtualization / QEMU - Markus Armbruster [redhat.com] - 27 April 2015 05:46 UTC

Live migration with spice works like this today:

(1) client_migrate_info monitor cmd (2) spice server notifies client, client connects to target host. (3) qemu waits until spice client connect is finished. (4) send over vmstate (i.e. main part of live migration). (5) spice handover to target host.

(3) is implemented by making client_migrate_info a async monitor command. This is the only async monitor command we have.

The original reason to implement this dance was that qemu did not accept new tcp connections while the incoming migration was running, so (2) and (4) could not be done in parallel. That issue was fixed long ago though. Qemu version 1.3.0 (released Dec 2012) and newer happily accept tcp connects while the incoming migration runs.

Time to drop step (3). This patch does exactly that, by making the monitor command synchronous and removing the code needed to handle the async monitor command in ui/spice-core.c

3b5704b monitor: Make client_migrate_info synchronous
hmp-commands.hx | 3 +--
include/ui/qemu-spice.h | 7 ++-----
monitor.c | 5 ++---
qmp-commands.hx | 3 +--
ui/spice-core.c | 26 +++++---------------------
5 files changed, 11 insertions(+), 33 deletions(-)

Upstream: git.qemu.org

  • Share