vfs:glusterfs_fuse: treat ENOATTR as ENOENT

Enterprise / Samba - Michael Adam [samba.org] - 28 June 2019 12:52 EDT

The original implementation of the virtual xattr get_real_filename in gluster was misusing the ENOENT errno as the authoritative anwer that the file/dir that we were asking the real filename for does not exist. But since the getxattr call is done on the parent directory, this is a violation of the getxattr API which uses ENOENT for the case that the file/dir that the getxattr call is done against does not exist.

Now after a recent regression for fuse-mount re-exports due to gluster mapping ENOENT to ESTALE in the fuse-bridge, the gluster implementation is changed to more correctly return ENOATTR if the requested file does not exist.

This patch changes the glusterfs_fuse vfs module to treat ENOATTR as ENOENT to be fully functional again with latest gluster.

- Without this patch, samba against a new gluster will work correctly, but the get_real_filename optimization for a non-existing entry is lost.

- With this patch, Samba will not work correctly any more against
very old gluster servers: Those (correctly) returned ENOATTR always, which Samba originally interpreted as EOPNOTSUPP, triggering the expensive directory scan. With this patch, ENOATTR is interpreted as ENOENT, the authoritative answer that the requested entry does not exist, which is wrong unless it really does not exist.

fee8cf326bf vfs:glusterfs_fuse: treat ENOATTR as ENOENT
source3/modules/vfs_glusterfs_fuse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Upstream: gitweb.samba.org


  • Share