ARM: Add SystemTap probes to longjmp and setjmp

System Internals / glibc - Will Newton [linaro.org] - 25 February 2014 04:07 UTC

Now the ARM port implements pointer encryption for jmpbufs, gdb needs a SystemTap probe point in longjmp to determine the target PC of a call to longjmp. This patch implements the probe point in longjmp and a similar probe point in setjmp.

In order to have all the appropriate registers available to pass to the probe this reorders the layout of jmpbuf, putting the sp and lr registers at the start rather than the end, allowing them to be read and written sequentially.

Tested on armv7, no new failures in the glibc testsuite and confirmed that this fixes the gdb.base/longjmp.exp failures in the gdb testsuite.

ChangeLog:

2014-02-25 Will Newton

- sysdeps/arm/__longjmp.S: Include stap-probe.h. (__longjmp): Restore sp and lr before restoring callee saved registers. Add longjmp and longjmp_target SystemTap probe point.
- sysdeps/arm/bits/setjmp.h (__jmp_buf): Update comment.
- sysdeps/arm/include/bits/setjmp.h (__JMP_BUF_SP): Define to zero to match jmpbuf layout.
- sysdeps/arm/setjmp.S: Include stap-probe.h. (__sigsetjmp): Save sp and lr before saving callee saved registers. Add setjmp SystemTap probe point.

80a56cc ARM: Add SystemTap probes to longjmp and setjmp.
ChangeLog | 13 ++++++++
sysdeps/arm/__longjmp.S | 61 ++++++++++++++++++++++---------------
sysdeps/arm/bits/setjmp.h | 5 ++-
sysdeps/arm/include/bits/setjmp.h | 2 +-
sysdeps/arm/setjmp.S | 12 ++++++--
5 files changed, 62 insertions(+), 31 deletions(-)

Upstream: sourceware.org


  • Share